1067893 - Detect OTOOL in configure and use it for all 'otool' calls

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Georg Koppen]

Similar to how STRIP, RANLIB etc. work we should detect OTOOL in configure and use its value instead of 'otool'.

Comment 1

[Georg Koppen]

Attachment: Detect OTOOL in configure - 1067893.patch

I adapted the otool calls in a all python files. Try is green for Linux/OS X/Windows https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=7c1341f44a00 and Tor Browser is building as well with the patch. Not sure what to do with the remaining unchanged otool calls. Any opinions?

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8526760 [details] [diff] [review]
Detect OTOOL in configure - 1067893.patch

Review of attachment 8526760 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/tools/gyp/test/mac/gyptest-installname.py
@@ +13,5 @@
>  
>  import re
>  import subprocess
>  import sys
> +from buildconfig import substs

Please don't touch the files under media/webrtc/trunk/tools/gyp/test, they're third-party and not used.

::: tools/rb/fix_macosx_stack.py
@@ +49,5 @@
>  address_adjustments = {}
>  def address_adjustment(file):
>      if not file in address_adjustments:
>          result = None
> +        otool = subprocess.Popen([substs['OTOOL'], "-l", file], stdout=subprocess.PIPE)

This doesn't usually run in a build environment, so using substs here won't work. That said, since it's not used during the build, let's leave it as it is for now.

Comment 3

[Georg Koppen]

Attachment: Detect OTOOL in configure v2 - 1067893.patch

Thanks for the comments. I addressed them and attached an updated patch.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f67efecf1b4

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9f67efecf1b4