1067937 - Link clicker UI broken with Google Chrome on Windows 7 (in non-English locales)

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Romain Testard [:RT]]

Using Google Chrome (37.0.2062.120 m) on Windows 7 to access to a Loop URL provides a blank page with the following JS info:


TB.setLogLevel(5)
OpenTok JavaScript library v2.2.7.2
Release notes:
http://www.tokbox.com/opentok/webrtc/docs/js/release-notes.html
Known issues:
http://www.tokbox.com/opentok/webrtc/docs/js/release-notes.html#knownIssues
OT.setLogLevel(5)
Download the React DevTools for a better development experience:
http://fb.me/react-devtools
Failed to load resource: the server responded with a status of 404 (Not
Found) https://call.mozilla.com/l10n/loop.fr.properties
Uncaught TypeError: undefined is not a function

Comment 1

[Mark Banner (:standard8)]

Attachment: Fix translation of Loop's link-clicker UI in Google Chrome.

I took a look at this. There were two issues with the l10n.js file we were using:

- Chrome didn't like a call to what was effectively console.error.apply (or maybe console.apply, never did quite work it out).
- l10n.js was adding the browser language to the supported locales even though it wasn't.

Happily, the most recent changes to l10n.js fix this. So all we need to do is to upgrade to it.

Unfortunately, the new version is based around webapps, and expects a manifest, rather than a .ini file. As I've not really got an idea of what adding a manifest might do to us, I've gone for the simple option of defining meta tags for the time being. We'll probably want to consider a way to tweak those when we start adding languages, but I think we can put it off until then.

Like the old one, l10n.js is unmodified from the gaia revision stated in its filename.

Comment 2

[Mark Banner (:standard8)]

History of the file is here btw: https://github.com/mozilla-b2g/gaia/commits/master/shared/js/l10n.js

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8490374 [details] [diff] [review]
Fix translation of Loop's link-clicker UI in Google Chrome.

r=dmose

Comment 4

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/6d51bb8b7666

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6d51bb8b7666

Comment 6

[u279076]

Paul, can you please verify this in the latest Nightly? We'll skip verification in the Fig builds but we'll want a Moztrap test for this in Loop 34 and 35.

Comment 7

[Paul Silaghi, QA [:pauly]]

Verified fixed Chrome 37.0.2062.124 vs Nighly 35.0a1 (2014-09-30) AR, FR, IT Win 7 x64

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8490374 [details] [diff] [review]
Fix translation of Loop's link-clicker UI in Google Chrome.

Approval Request Comment
Uplift request for patches staged and tested on Fig

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ff1504790226

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8490374 [details] [diff] [review]
Fix translation of Loop's link-clicker UI in Google Chrome.

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.

Comment 11

[u279076]

Paul, can you please test this on Aurora now that it's been uplifted?

Comment 12

[Paul Silaghi, QA [:pauly]]

Verified fixed Chrome 38.0.2125.101 vs FF 34b1 AR, FR, DE Win 7 x64