Closed Bug 1067937 Opened 5 years ago Closed 5 years ago
Link clicker UI broken with Google Chrome on Windows 7 (in non-English locales)
I took a look at this. There were two issues with the l10n.js file we were using: - Chrome didn't like a call to what was effectively console.error.apply (or maybe console.apply, never did quite work it out). - l10n.js was adding the browser language to the supported locales even though it wasn't. Happily, the most recent changes to l10n.js fix this. So all we need to do is to upgrade to it. Unfortunately, the new version is based around webapps, and expects a manifest, rather than a .ini file. As I've not really got an idea of what adding a manifest might do to us, I've gone for the simple option of defining meta tags for the time being. We'll probably want to consider a way to tweak those when we start adding languages, but I think we can put it off until then. Like the old one, l10n.js is unmodified from the gaia revision stated in its filename.
Attachment #8490374 - Flags: review?(dmose)
History of the file is here btw: https://github.com/mozilla-b2g/gaia/commits/master/shared/js/l10n.js
Assignee: nobody → standard8
OS: Windows 7 → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla35
Summary: Link clicker UI broken with Google Chrome on Windows 7 → Link clicker UI broken with Google Chrome on Windows 7 (in non-English locales)
Comment on attachment 8490374 [details] [diff] [review] Fix translation of Loop's link-clicker UI in Google Chrome. r=dmose
Attachment #8490374 - Flags: review?(dmose) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Paul, can you please verify this in the latest Nightly? We'll skip verification in the Fig builds but we'll want a Moztrap test for this in Loop 34 and 35.
QA Contact: anthony.s.hughes → paul.silaghi
Verified fixed Chrome 37.0.2062.124 vs Nighly 35.0a1 (2014-09-30) AR, FR, IT Win 7 x64
Comment on attachment 8490374 [details] [diff] [review] Fix translation of Loop's link-clicker UI in Google Chrome. Approval Request Comment Uplift request for patches staged and tested on Fig
Attachment #8490374 - Flags: approval-mozilla-aurora?
Comment on attachment 8490374 [details] [diff] [review] Fix translation of Loop's link-clicker UI in Google Chrome. I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.
Attachment #8490374 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Paul, can you please test this on Aurora now that it's been uplifted?
Flags: in-moztrap? → needinfo?(paul.silaghi)
Verified fixed Chrome 38.0.2125.101 vs FF 34b1 AR, FR, DE Win 7 x64
You need to log in before you can comment on or make changes to this bug.