Closed Bug 1067984 Opened 6 years ago Closed 6 years ago

crash in js::jit::LazyLinkTopActivation(JSContext*)

Categories

(Core :: JavaScript Engine: JIT, defect)

35 Branch
All
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: aaronmt, Assigned: h4writer)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-1739cc53-a4da-4a67-8c91-2f0652140915.
=============================================================
Flags: needinfo?(hv1989)
This is caused by landing of bug 1047346.
Blocks: 1047346
Flags: needinfo?(hv1989)
Quick fix by disabling lazy linking for ARM temporarily. This is because the arm assembly of the lazy link stub is incorrect (as stated by you in bug 1047346 comment 11). I want to address your comments later this week. (After urgent stuff after week PTO is done). But let us remove this crash source.
Assignee: nobody → hv1989
Attachment #8493262 - Flags: review?(mrosenberg)
Comment on attachment 8493262 [details] [diff] [review]
Disable lazy linking for arm

Review of attachment 8493262 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/Ion.cpp
@@ +1848,5 @@
>          }
>          if (!builder)
>              break;
>  
> +#if defined(JS_CODEGEN_X86) || defined(JS_CODEGEN_X64)

Add comment:

// TODO bug 1047346: Enable lazy linking for other architectures again by fixing the lazy link stub.
Comment on attachment 8493262 [details] [diff] [review]
Disable lazy linking for arm

Review of attachment 8493262 [details] [diff] [review]:
-----------------------------------------------------------------

Seems straightforward enough.
Attachment #8493262 - Flags: review?(mrosenberg) → review+
https://hg.mozilla.org/mozilla-central/rev/0c8fa599e889
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Duplicate of this bug: 1071068
You need to log in before you can comment on or make changes to this bug.