1068058 - Update Selection.containsNode according to the spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

Specifically, this makes the first argument non-nullable.

Comment 1

[(no longer active)]

Attachment: Update Selection.containsNode according to the spec

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8490107 [details] [diff] [review]
Update Selection.containsNode according to the spec

>+Selection::ContainsNode(nsINode& aNode, bool aAllowPartial, ErrorResult& aRv)
> {
>   nsresult rv;
>-  if (mRanges.Length() == 0 || !aNode)
>+  if (mRanges.Length() == 0)
>     return false;
Since you're fixing coding style elsewhere, why not here too

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae2e4ca015fd

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ae2e4ca015fd

Comment 5

[Jean-Yves Perrier [:teoli]]

Doc updated:
https://developer.mozilla.org/en-US/Firefox/Releases/35#Interfaces.2FAPIs.2FDOM
and
https://developer.mozilla.org/en-US/docs/Web/API/Selection.containsNode#Browser_compatibility