1068176 - Session Manager stops working in Nightly35.0a1

Status: VERIFIED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Alice0775 White]

Steps To Reproduce:
0. Disable e10s
1. Install Session Manager Dev version from http://downloads.mozdev.org/sessionmanager/session_manager_dev_public.xpi

Actual Results:
No Toolbar button displayed.
Session Manager's option dialog is broken.

Regession window(m-c)
Good:
https://hg.mozilla.org/mozilla-central/rev/a5ece9451343
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20140915162532
Bad:
https://hg.mozilla.org/mozilla-central/rev/4e8c6c5c0961
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20140915200133
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a5ece9451343&tochange=4e8c6c5c0961


Regession window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/170ce237e4a0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20140915155135
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fada58fb0996
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20140915163234
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=170ce237e4a0&tochange=fada58fb0996

Regressed by: Bug 1001090

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

Same with Privacy Badger (https://github.com/EFForg/privacybadgerfirefox | https://addons.mozilla.org/firefox/addon/privacy-badger-firefox/):
* no toolbar button
* in its two option it states "undefined"

Comment 2

[Jeff Walden [:Waldo]]

This is likely an issue with the addon wrt new let semantics.  I did a quick skim of some of the likely-looking files that could be misusing let and didn't find any actually using let at all, but I assume I just didn't search hard enough.

Comment 3

[Jeff Walden [:Waldo]]

Privacy Badger too also probably needs updating.

Comment 4

[Alice0775 White]

Filed in Session Manager's bug tracker:
https://www.mozdev.org/bugs/show_bug.cgi?id=25851

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

FWIW, filed https://github.com/EFForg/privacybadgerfirefox/issues/218 against Privacy Badger

Comment 6

[Michael Kraft [:morac]]

Session Manager's developer channel version has been updated to fix this.

Problem was that a variable was declared twice in the same block with a "let" statement in the bootstrap.js code.  

Example:

let win = .....
if (win) {
 ....
}
let win = .....