Session Manager stops working in Nightly35.0a1

VERIFIED FIXED

Status

()

VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: alice0775, Unassigned)

Tracking

({addon-compat})

35 Branch
x86_64
Windows 7
addon-compat
Points:
---

Firefox Tracking Flags

(firefox34 unaffected, firefox35 verified)

Details

(Whiteboard: [fixed from Session Manager 0.8.1.6pre20140916b])

(Reporter)

Description

4 years ago
Steps To Reproduce:
0. Disable e10s
1. Install Session Manager Dev version from http://downloads.mozdev.org/sessionmanager/session_manager_dev_public.xpi

Actual Results:
No Toolbar button displayed.
Session Manager's option dialog is broken.

Regession window(m-c)
Good:
https://hg.mozilla.org/mozilla-central/rev/a5ece9451343
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20140915162532
Bad:
https://hg.mozilla.org/mozilla-central/rev/4e8c6c5c0961
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20140915200133
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a5ece9451343&tochange=4e8c6c5c0961


Regession window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/170ce237e4a0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20140915155135
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fada58fb0996
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20140915163234
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=170ce237e4a0&tochange=fada58fb0996

Regressed by: Bug 1001090
Same with Privacy Badger (https://github.com/EFForg/privacybadgerfirefox | https://addons.mozilla.org/firefox/addon/privacy-badger-firefox/):
* no toolbar button
* in its two option it states "undefined"

Comment 2

4 years ago
This is likely an issue with the addon wrt new let semantics.  I did a quick skim of some of the likely-looking files that could be misusing let and didn't find any actually using let at all, but I assume I just didn't search hard enough.

Comment 3

4 years ago
Privacy Badger too also probably needs updating.
(Reporter)

Comment 4

4 years ago
Filed in Session Manager's bug tracker:
https://www.mozdev.org/bugs/show_bug.cgi?id=25851
Session Manager's developer channel version has been updated to fix this.

Problem was that a variable was declared twice in the same block with a "let" statement in the bootstrap.js code.  

Example:

let win = .....
if (win) {
 ....
}
let win = .....

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
status-firefox35: affected → verified
Whiteboard: [fixed from Session Manager 0.8.1.6pre20140916b]
You need to log in before you can comment on or make changes to this bug.