1068178 - end to end call test broken by pending call view cahnges

Status: RESOLVED FIXED

(Hello (Loop) :: General, defect)

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Fix Loop functional test breakage, DONTBUILD

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Fix Loop functional test bustage, rs=Standard8, NPOTB, so DONTBUILD

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8490251 [details] [diff] [review]
Fix Loop functional test bustage, rs=Standard8, NPOTB, so DONTBUILD

Review of attachment 8490251 [details] [diff] [review]:
-----------------------------------------------------------------

rs=Standard8 over IRC

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

https://hg.mozilla.org/integration/fx-team/rev/ad92c85dce35

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad92c85dce35

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

While we don't technically have to uplift this, I'd strongly suggest we do, so that we can easily check that other uplifted changes haven't broken at least the basic functionality.  Adding [loop-uplift] whiteboard markup.

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8490251 [details] [diff] [review]
Fix Loop functional test bustage, rs=Standard8, NPOTB, so DONTBUILD

Approval Request Comment
Uplift request for patches staged and tested on Fig

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/19f2399950b5

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8490251 [details] [diff] [review]
Fix Loop functional test bustage, rs=Standard8, NPOTB, so DONTBUILD

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.