end to end call test broken by pending call view cahnges

RESOLVED FIXED in Firefox 34

Status

Hello (Loop)
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dmose, Assigned: dmose)

Tracking

unspecified
mozilla35
x86
All
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox34 fixed, firefox35 fixed)

Details

(Whiteboard: [loop-uplift])

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Assignee: nobody → dmose
(Assignee)

Comment 1

4 years ago
Created attachment 8490240 [details] [diff] [review]
Fix Loop functional test breakage, DONTBUILD
(Assignee)

Comment 2

4 years ago
Created attachment 8490251 [details] [diff] [review]
Fix Loop functional test bustage, rs=Standard8, NPOTB, so DONTBUILD
Attachment #8490240 - Attachment is obsolete: true
(Assignee)

Comment 3

4 years ago
Comment on attachment 8490251 [details] [diff] [review]
Fix Loop functional test bustage, rs=Standard8, NPOTB, so DONTBUILD

Review of attachment 8490251 [details] [diff] [review]:
-----------------------------------------------------------------

rs=Standard8 over IRC
Attachment #8490251 - Flags: review+
(Assignee)

Updated

4 years ago
Blocks: 1000237
https://hg.mozilla.org/mozilla-central/rev/ad92c85dce35
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
(Assignee)

Comment 6

4 years ago
While we don't technically have to uplift this, I'd strongly suggest we do, so that we can easily check that other uplifted changes haven't broken at least the basic functionality.  Adding [loop-uplift] whiteboard markup.
Whiteboard: [loop-uplift]
Flags: qe-verify-
Comment on attachment 8490251 [details] [diff] [review]
Fix Loop functional test bustage, rs=Standard8, NPOTB, so DONTBUILD

Approval Request Comment
Uplift request for patches staged and tested on Fig
Attachment #8490251 - Flags: approval-mozilla-aurora?

Updated

4 years ago
status-firefox34: --- → fixed
status-firefox35: --- → fixed
Comment on attachment 8490251 [details] [diff] [review]
Fix Loop functional test bustage, rs=Standard8, NPOTB, so DONTBUILD

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.
Attachment #8490251 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.