1068204 - [Utility Tray] Cannot swipe left to dismiss notifications

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

STR:

1.) Take a screenshot (or trigger a notification in any way)
2.) Open utility tray
3.) Swipe left on the newly created notification

Actual result:
Notification does not move left, but instead only highlights in blue.

Expected result:
Notification can be dismissed by swiping left.

It is worth noting that if you initiate the swipe by swiping right a little way, then you can swipe left to dismiss the notification. But you cannot initiated the dismissal swipe by swiping left.

Comment 1

[Guillaume Marty [:gmarty]]

Attachment: Github PR

Nice catch Michael. I hadn't realised you are left-handed :-)

Fernando, can you have a look at the patch? Thanks.

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8490717 [details] [review]
Github PR

LGTM, but I really have no idea about this module.

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 8490717 [details] [review]
Github PR

Thanks! I was hitting this all the time :)

Comment 4

[Guillaume Marty [:gmarty]]

Thanks Etienne. Merged in https://github.com/mozilla-b2g/gaia/commit/f5e41cebfcafa475ef62aebc7a72448af021cc11

Comment 5

[Guillaume Marty [:gmarty]]

Comment on attachment 8490717 [details] [review]
Github PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Swipe to dismiss notifications in utility tray
[User impact] if declined: Less good UX specially for left-handed users.
[Testing completed]: Manual testing
[Risk to taking this patch] (and alternatives if risky): Minor patch
[String changes made]: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/dd8c76dd22baf320ae99bc0fb24f94527e90c177

Comment 7

[Tony Chung [:tchung]]

verifyme on 2.1 branch

Comment 8

[Duane Dixon [:ddixon]]

Issue is verified fixed in Flame 2.2, 2.1 (Full Flash, Nightly). 

Actual Results: User is able to swipe Notifications to the left which dismisses them. 

Device: Flame Master
Build ID: 20141014040203
Gaia: 4f86c631e0465c0e56ccebeb1324fd28be9ea32f
Gecko: 54217864bae9
Version: 36.0a1 (Master)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1
Build ID: 20141014001201
Gaia: 7e2e65a9668123b54c8cce5dacfdba6f4bd4672b
Gecko: 2325da834971
Version: 34.0 (2.1)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0