1068224 - Limit the amount of calls shown in the call info view

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Doug Sherk (:drs) (inactive)]

The number of calls that the call info view currently shows is unlimited. This can make one call info view extend to several pages, which I think is quite bad for UX.

Comment 1

[Doug Sherk (:drs) (inactive)]

There are 3 solutions I can think of for this:
1) We just hard limit the amount of calls that we display to a certain number.
2) We limit the amount of calls that we display, and offer a "show more" button or similar.
3) We don't do anything.

Carrie, thoughts? I would be inclined to go for 2. As always, we're open to suggestions.

Comment 2

[Rigin Oommen]

If a contact have two numbers in one entry. then too the call logs become in a long list.

I have a suggestion to solve this

1)As you said above we can fix this by using offers "Show Nore" or sample contact "[phone] (10)" (10) means no of times about the action

Comment 3

[Doug Sherk (:drs) (inactive)]

Rigin, are you interested in working on this once we come to a consensus on the UX? I'm not sure if you're looking to contribute or not, but if so I'd be happy to provide mentorship and help you get set up.

Comment 4

[Rigin Oommen]

YES I am not giving an assurance on success. let me try my level best

Comment 5

[Doug Sherk (:drs) (inactive)]

Ok, great! I'm assigning this to you for now. Please don't hesitate to ask me questions. I would suggest starting here:
https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia

Are you on IRC? If not, this will help you get setup:
https://wiki.mozilla.org/IRC

You can join #fxos-dialer and #gaia, though the former is better to talk with us about this bug.

Until we get consensus on the UX, this bug isn't actually actionable. But we can get you set up so that you're ready to go once we know what we're doing.

Comment 6

[Carrie Wang [New account: [e-mail]]]

Hi, 

I've checked it with Carol and we tried to figure out the magic number of the call history displayed here.
We'd suggest showing 9 call logs and add a tappable wording "show more" (with underline) underneath these call logs (so there will be ten lines here). 

Besides, the case that Rigin mentioned in comment 2 will not happen. Because we will not combine the calls from different numbers of a contact into one call info. We will separate them into two different entries. Thanks!

Comment 7

[Doug Sherk (:drs) (inactive)]

Thanks, Carrie.

Rigin, have you had a chance to get set up? Also, do you have a device to test on?

Comment 8

[Rigin Oommen]

Yes I Have the Device(KEON) but it is bricked up while on S/w Updation on Firefox OS 2.0

Comment 9

[Rigin Oommen]

Currently i am in the build process

Comment 10

[Rabbi Hossain]

Anyone working on this? I think I can help here :)
But I need some screenshots to understand it clearly. :carrie or :drs , can you help ?

Comment 11

[Rigin Oommen]

I am working on it. let us do it together.

actually it is an extension idea for the logs.

Comment 12

[Doug Sherk (:drs) (inactive)]

Attachment: Screenshot of issue.

Here's a screenshot of the issue.

I'm happy that both of you want to work on this and we appreciate your interest. You can both work on this if you'd like to, but in general, it's best to have one person working on each bug.

We have other unassigned mentored bugs that you can find here:
https://wiki.mozilla.org/FirefoxOS/Comms/Dialer#Mentored_bugs

Please don't hesitate to comment or ask questions.

Comment 13

[Rabbi Hossain]

(In reply to Rigin Oommen from comment #11)
> I am working on it. let us do it together.
> 
> actually it is an extension idea for the logs.

It's great to see that you are working. Can I see your git repo? So that I can give you a PR and collaborate with you.

Comment 14

[Rigin Oommen]

My Git Profile Link
http://github.com/riginoommen

This Bug is partially fixed in Firefox 2.2 Nightly version.

http://downloads.geeksphone.com/keon/master/latest_master.html

Comment 15

[Doug Sherk (:drs) (inactive)]

Hi guys, are either of you working on this?

Comment 16

[Rabbi Hossain]

Hi :drs, since Rigin is working on it. I haven't touch it. I moved onto another bug. If he is not working, then I can work after this week.

Comment 17

[Rigin Oommen]

Hi all in the nightly version of firefox os 2.2 this bug is fixed. i recently checked

Comment 18

[Doug Sherk (:drs) (inactive)]

(In reply to Rigin Oommen from comment #17)
> Hi all in the nightly version of firefox os 2.2 this bug is fixed. i
> recently checked

It's not, unfortunately. Do you need any help here?

Comment 19

[Doug Sherk (:drs) (inactive)]

Unassigning as the assignee has disappeared. Please feel free to comment if you return.

Comment 20

[Mike Hoye [:mhoye]]

Rabbi, it looks like Rigin has stepped away from this. Do you want to take a run at it?

Comment 21

[Rabbi Hossain]

I would love to work on it. Let me take a look at this bug

Comment 22

[Mike Hoye [:mhoye]]

Hit it.

Comment 23

[ankitladhania]

i would like to do it but this would be my first bug

Comment 24

[Kai-Chih Hu [:khu]]

Looks like no one is working on it? I can also work on it, but I may need mentorship...

Comment 25

[Doug Sherk (:drs) (inactive)]

(In reply to Kevin Hu [:khu] from comment #24)
> Looks like no one is working on it? I can also work on it, but I may need
> mentorship...

Sure, I'm assigning this to you and I'll be available for any help that you need. Ankit (comment 23) has been inactive for several weeks so I'm assuming that he dropped off after making that comment.

Comment 26

[Vishnu Teja [:ythej]]

Looks like no one is working on this.I am assigning to myself.

Thank you.

Comment 27

[Vishnu Teja [:ythej]]

Hi Doug,

Do we have to display all the calls when we press on show more button or we have to display only next 10 contacts and place a show more button below them?

Thank you.

Comment 28

[Doug Sherk (:drs) (inactive)]

(In reply to Vishnu Teja [:ythej] from comment #27)
> Hi Doug,
> 
> Do we have to display all the calls when we press on show more button or we
> have to display only next 10 contacts and place a show more button below
> them?
> 
> Thank you.

Redirecting to Carrie. I would say we should just show them all. There are a maximum of 100 calls in total. Since this number is shared between all contacts and numbers in the call log, it's unlikely that we'll ever have more than ~20-30 call records per entry.

Comment 29

[Carrie Wang [New account: [e-mail]]]

Hi, 

Agree on comment 28. Let's just display them all. It's unnecessary to divide a task into so many steps. Thanks!

Comment 30

[GitHub Autolander Bot]

Attachment: [gaia] ythej:bug_1068224 > mozilla-b2g:master

Comment 31

[Vishnu Teja [:ythej]]

Comment on attachment 8570950 [details] [review]
[gaia] ythej:bug_1068224 > mozilla-b2g:master

Hi Doug, 

I need to know if method of implementing is fine before doing tests.

Thank you.

Comment 32

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8570950 [details] [review]
[gaia] ythej:bug_1068224 > mozilla-b2g:master

Looks reasonable. I left some comments on the PR.

Comment 33

[Vishnu Teja [:ythej]]

Hi Doug,

Sorry that I didn't work on it for long time. I have updated the PR(very small changes). As you told I used slice for cutting down the no of div but couldn't get it working without adding/removing .hide-show-more class. Please checkout the PR and help me with exact way of implementing it.

Thank you.

Comment 34

[Doug Sherk (:drs) (inactive)]

I answered on the PR.

Comment 35

[BMO Automation]

Firefox OS is not being worked on