Closed Bug 1068224 Opened 8 years ago Closed 5 years ago

Limit the amount of calls shown in the call info view

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: drs, Unassigned, Mentored)

References

Details

(Whiteboard: [lang=js][lang=css])

Attachments

(2 files)

The number of calls that the call info view currently shows is unlimited. This can make one call info view extend to several pages, which I think is quite bad for UX.
There are 3 solutions I can think of for this:
1) We just hard limit the amount of calls that we display to a certain number.
2) We limit the amount of calls that we display, and offer a "show more" button or similar.
3) We don't do anything.

Carrie, thoughts? I would be inclined to go for 2. As always, we're open to suggestions.
Depends on: 877971
Flags: needinfo?(cawang)
If a contact have two numbers in one entry. then too the call logs become in a long list.

I have a suggestion to solve this

1)As you said above we can fix this by using offers "Show Nore" or sample contact "+910000000000 (10)" (10) means no of times about the action
Rigin, are you interested in working on this once we come to a consensus on the UX? I'm not sure if you're looking to contribute or not, but if so I'd be happy to provide mentorship and help you get set up.
Flags: needinfo?(riginoommen)
YES I am not giving an assurance on success. let me try my level best
Flags: needinfo?(riginoommen)
Flags: needinfo?(drs+bugzilla)
Ok, great! I'm assigning this to you for now. Please don't hesitate to ask me questions. I would suggest starting here:
https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia

Are you on IRC? If not, this will help you get setup:
https://wiki.mozilla.org/IRC

You can join #fxos-dialer and #gaia, though the former is better to talk with us about this bug.

Until we get consensus on the UX, this bug isn't actually actionable. But we can get you set up so that you're ready to go once we know what we're doing.
Assignee: nobody → riginoommen
Mentor: drs+bugzilla
Flags: needinfo?(drs+bugzilla)
Whiteboard: [good first bug][lang=js][lang=css]
Hi, 

I've checked it with Carol and we tried to figure out the magic number of the call history displayed here.
We'd suggest showing 9 call logs and add a tappable wording "show more" (with underline) underneath these call logs (so there will be ten lines here). 

Besides, the case that Rigin mentioned in comment 2 will not happen. Because we will not combine the calls from different numbers of a contact into one call info. We will separate them into two different entries. Thanks!
Flags: needinfo?(cawang)
Thanks, Carrie.

Rigin, have you had a chance to get set up? Also, do you have a device to test on?
Flags: needinfo?(riginoommen)
Yes I Have the Device(KEON) but it is bricked up while on S/w Updation on Firefox OS 2.0
Flags: needinfo?(riginoommen)
Currently i am in the build process
QA Whiteboard: [Callinfo
QA Whiteboard: [Callinfo → [Callinfo]
Anyone working on this? I think I can help here :)
But I need some screenshots to understand it clearly. :carrie or :drs , can you help ?
Flags: needinfo?(drs+bugzilla)
Flags: needinfo?(cawang)
I am working on it. let us do it together.

actually it is an extension idea for the logs.
Attached image Screenshot of issue.
Here's a screenshot of the issue.

I'm happy that both of you want to work on this and we appreciate your interest. You can both work on this if you'd like to, but in general, it's best to have one person working on each bug.

We have other unassigned mentored bugs that you can find here:
https://wiki.mozilla.org/FirefoxOS/Comms/Dialer#Mentored_bugs

Please don't hesitate to comment or ask questions.
Flags: needinfo?(drs+bugzilla)
Flags: needinfo?(cawang)
(In reply to Rigin Oommen from comment #11)
> I am working on it. let us do it together.
> 
> actually it is an extension idea for the logs.

It's great to see that you are working. Can I see your git repo? So that I can give you a PR and collaborate with you.
Flags: needinfo?(riginoommen)
My Git Profile Link
http://github.com/riginoommen

This Bug is partially fixed in Firefox 2.2 Nightly version.

http://downloads.geeksphone.com/keon/master/latest_master.html
Flags: needinfo?(riginoommen)
Hi guys, are either of you working on this?
Flags: needinfo?(riginoommen)
Flags: needinfo?(me)
Hi :drs, since Rigin is working on it. I haven't touch it. I moved onto another bug. If he is not working, then I can work after this week.
Flags: needinfo?(me)
Hi all in the nightly version of firefox os 2.2 this bug is fixed. i recently checked
Flags: needinfo?(riginoommen)
(In reply to Rigin Oommen from comment #17)
> Hi all in the nightly version of firefox os 2.2 this bug is fixed. i
> recently checked

It's not, unfortunately. Do you need any help here?
Flags: needinfo?(riginoommen)
Unassigning as the assignee has disappeared. Please feel free to comment if you return.
Assignee: riginoommen → nobody
Rabbi, it looks like Rigin has stepped away from this. Do you want to take a run at it?
Flags: needinfo?(me)
I would love to work on it. Let me take a look at this bug
Flags: needinfo?(me)
Hit it.
i would like to do it but this would be my first bug
Looks like no one is working on it? I can also work on it, but I may need mentorship...
(In reply to Kevin Hu [:khu] from comment #24)
> Looks like no one is working on it? I can also work on it, but I may need
> mentorship...

Sure, I'm assigning this to you and I'll be available for any help that you need. Ankit (comment 23) has been inactive for several weeks so I'm assuming that he dropped off after making that comment.
Assignee: nobody → khu
Flags: needinfo?(riginoommen)
Looks like no one is working on this.I am assigning to myself.

Thank you.
Assignee: khu → yvtheja
Status: NEW → ASSIGNED
Hi Doug,

Do we have to display all the calls when we press on show more button or we have to display only next 10 contacts and place a show more button below them?

Thank you.
Flags: needinfo?(drs.bugzilla)
(In reply to Vishnu Teja [:ythej] from comment #27)
> Hi Doug,
> 
> Do we have to display all the calls when we press on show more button or we
> have to display only next 10 contacts and place a show more button below
> them?
> 
> Thank you.

Redirecting to Carrie. I would say we should just show them all. There are a maximum of 100 calls in total. Since this number is shared between all contacts and numbers in the call log, it's unlikely that we'll ever have more than ~20-30 call records per entry.
Flags: needinfo?(drs.bugzilla) → needinfo?(cawang)
Hi, 

Agree on comment 28. Let's just display them all. It's unnecessary to divide a task into so many steps. Thanks!
Flags: needinfo?(cawang)
Comment on attachment 8570950 [details] [review]
[gaia] ythej:bug_1068224 > mozilla-b2g:master

Hi Doug, 

I need to know if method of implementing is fine before doing tests.

Thank you.
Attachment #8570950 - Flags: feedback?(drs.bugzilla)
Comment on attachment 8570950 [details] [review]
[gaia] ythej:bug_1068224 > mozilla-b2g:master

Looks reasonable. I left some comments on the PR.
Attachment #8570950 - Flags: feedback?(drs.bugzilla) → feedback+
Hi Doug,

Sorry that I didn't work on it for long time. I have updated the PR(very small changes). As you told I used slice for cutting down the no of div but couldn't get it working without adding/removing .hide-show-more class. Please checkout the PR and help me with exact way of implementing it.

Thank you.
Flags: needinfo?(drs)
I answered on the PR.
Flags: needinfo?(drs)
Assignee: yvtheja → nobody
Status: ASSIGNED → NEW
Whiteboard: [good first bug][lang=js][lang=css] → [lang=js][lang=css]
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.