1068360 - [e10s] Mixed content blocker doorhanger doesn't work

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Dave Townsend [:mossop]]

The doorhanger code tries to manipulate the docshell directly and so fails. I'm disabling browser_bug1045809.js because of this.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: mixedcontent

Just to make the doorhanger work, the isMixedContentAllowed changes weren't strictly necessary. But fixing the "open in new tab" handlers together was simple so I included it here

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8508771 [details] [diff] [review]
mixedcontent

Review of attachment 8508771 [details] [diff] [review]:
-----------------------------------------------------------------

I think this looks ok but I'd like Monica to see it too.

Comment 3

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8508771 [details] [diff] [review]
mixedcontent

Review of attachment 8508771 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Felipe! I think the same fix might be needed for re-enabling tracking protection.

Comment 4

[[:mmc] Monica Chew (no longer reading bugmail)]

(In reply to [:mmc] Monica Chew (please use needinfo) from comment #3)
> Comment on attachment 8508771 [details] [diff] [review]
> mixedcontent
> 
> Review of attachment 8508771 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks, Felipe! I think the same fix might be needed for re-enabling
> tracking protection.

Fortunately it looks like I am wrong -- tracking protection just clears the permission manager and reloads the page.

https://mxr.mozilla.org/mozilla-central/source/browser/base/content/urlbarBindings.xml#1861

Comment 5

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/fx-team/rev/a05887ec8655

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Thanks for the reviews. I left the .isMixedContentAllowed change for now because I'm gonna wait for bug 1084504 to be able to fully make sure it works. But I'll follow up on that in a separate bug because the most important part (the doorhanger) which is covered by this bug is now fixed.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a05887ec8655

Comment 8

[Marco Mucci [:MarcoM]]

Hi Felipe, can you mark this bug for QE verification.

Comment 9

[:Felipe Gomes (needinfo for replies!)]

No need for QE verification as there is an automated test that got enabled in this bug and is passing.