1068382 - Switch to use multilocale.js for every build

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

We currently only run multilocale if LOCALE_BASEDIR is set.

This means that for builds without that, we kind of don't have a good place in our build system to resolve the magic of branding and device_type and we don't localize manifest.webapp.

I'd like to switch the system to use multilocale processing wherever we use LOCALE_BASEDIR or not.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

It actually will be useful for bug 1115807 so that we can handle meta localization in multilocale. Taking.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

Very simple change. I basically enable multilocale, but don't do anything in it unless LOCALE_BASEDIR is specified. With those changes running getResources will work without basedir, but I don't need it for now.

The biggest change is that with multilocale running for non basedir enabled build, I can then add meta localization in bug 1115807 and in the future we will be able to easily turn l10n resource gathering for non-basedir builds here.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8541826 [details] [review]
pull request

Alexandre, can you review this? It basically turns on multilocale.js for builds without LOCALE_BASEDIR in order to centralize l10n related functionality for all builds in that script.

It shouldn't cost any more time because still the l10nManager.localize only runs the actual code for builds with the basedir, but in bug 1115807 I will add one more piece of logic to localize <meta> key in HTML files and this one will be enabled for all builds.

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8541826 [details] [review]
pull request

Looks good.

Comment 5

[Staś Małolepszy :stas]

This should be also very useful for bug 1101632 and for running the pseudolocales logic on buildtime.  Thanks, Zibi!

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/5bef98fc59306aa8cbbf7285448505c8dab03a21
Merge: https://github.com/mozilla-b2g/gaia/commit/f56224529f88933bcffef89981dfe2d90fa98038