1068442 - Add marionette test for SHB on secure window

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

Opening this bug to track the attempt at adding a marionette test to check visibility of the SHB on a secure fullscreen window.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8490841 [details] [review]
Github pull request

Alive - I'd like you to take a look at this if you have the time. This patch allows us to enable the SHB on desktop so we can write marionette tests against it. Mobile devices will still turn it on by default if they do not have a hardware button, and the desktop client can enable it by toggling the setting.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8490841 [details] [review]
Github pull request

The 'secure window' is confusing me because we have a SecureWindow class. But this looks fine I think.

Comment 4

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/b3d5258dfa82225beff03bc8b294b8660aaef95d

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8490841 [details] [review]
Github pull request

Fabrice - wondering if we can get this into v2.1. We currently have several failing software home button tests on the v2.1 branch because this never made it to that branch. This commit allows us to test the software home button against the v2.1 branch by modifying some checks in the system app. Before the system app would not allow you to turn on the software home button on desktop, this changes that. 

I would like to see this uplifted as the software home button is an important part of v2.1, and without this we have no way of knowing if we are breaking things.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Original implementation.
[User impact] if declined: No user impact, but may help us ship a more stable, tested product.
[Testing completed]: This was only for tests, and is almost a=testonly, but there is two lines of code that were modified to support these tests.
[Risk to taking this patch] (and alternatives if risky): I think this is extremely low risk.
[String changes made]: None.

Comment 7

[Kevin Grandon :kgrandon]

In v2.1: https://github.com/mozilla-b2g/gaia/commit/1986e78aee70016b6fb6478ffeb3341f01c316a9