1068444 - Ensure that we use confirm-channels

Status: RESOLVED INVALID

(Webtools :: Pulse, defect, P2)

Description

[Jonas Finnemann Jensen (:jonasfj)]

By default most AMQP libraries don't use confirm-channels, in particularly not for message publication.
This does affect performance, especially if we block while waiting for acknowledgement that a message was published.
This is the case in python, for node waiting for confirmation can be done asynchronously.

Anyways, we should probably block on ack, and see if it has significant performance implications. In cases where we send a lot of messages at once, one could make a method that blocks on all of them to finish.

Note: This is purely a client-side issue, also we probably want to use confirm channels for both consuming and publishing messages.

Information I've been able to find on this issue for python is limited:
 - https://github.com/celery/py-amqp/issues/3
I have not been able to get any of it working with kombu.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Note: This is purely a client-side issue, also we probably want to use confirm channels for both consuming and publishing messages.

Yup. I think when this was filed we had planned to ship client libraries for each language, but that's no longer the case, so this is not something the pulse owners can do.