Closed
Bug 1068494
Opened 10 years ago
Closed 10 years ago
Remove CVS/Bonsai/LXR-specific bits of Patch Viewer
Categories
(Bugzilla :: Attachments & Requests, enhancement)
Bugzilla
Attachments & Requests
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: gerv, Assigned: LpSolit)
Details
Attachments
(1 file)
20.90 KB,
patch
|
gerv
:
review+
|
Details | Diff | Splinter Review |
Patch Viewer allows one to view patches, which is nice, but it also has CVS, LXR and Bonsai integration. Even Mozilla doesn't use this any more. We should remove it.
Gerv
Assignee | ||
Updated•10 years ago
|
Assignee: general → attach-and-request
Severity: normal → enhancement
Component: Bugzilla-General → Attachments & Requests
OS: Linux → All
Hardware: x86 → All
Assignee | ||
Comment 1•10 years ago
|
||
I think I need this bug to be fixed to fully fix bug 1073271.
Assignee: attach-and-request → LpSolit
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Actually no, I don't need this bug to fix bug 1073271. But now that I wrote it... :)
Attachment #8504422 -
Flags: review?(gerv)
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8504422 [details] [diff] [review]
patch, v1
Review of attachment 8504422 [details] [diff] [review]:
-----------------------------------------------------------------
I applied the patch and got an error about Bugzilla/Config/PatchViewer.pm not returning a true value. It seems that this patch makes this file empty instead of deleting it. Removing it fixed the problem.
If you make sure you actually remove the file when checking in, r=gerv.
Gerv
Attachment #8504422 -
Flags: review?(gerv) → review+
Reporter | ||
Updated•10 years ago
|
Flags: approval?
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Gervase Markham [:gerv] from comment #3)
> I applied the patch and got an error about Bugzilla/Config/PatchViewer.pm
> not returning a true value. It seems that this patch makes this file empty
> instead of deleting it. Removing it fixed the problem.
Yes I know. That's what I initially did (removing the file), but then git was unable to include it in the diff (CVS and bzr were both able to do that, so I guess there is a trick with git to do it, but I don't know which one). Don't worry, I will make sure both files are gone. :)
Keywords: relnote
Target Milestone: --- → Bugzilla 5.0
Assignee | ||
Comment 5•10 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
7ce5b04..94ffb7a master -> master
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
this triggered a warning in t/012throwables.t:
# Failed test '--WARNING template/en/default/global/user-error.html.tmpl has 1 unused error tag(s):
# user error tag 'invalid_context' is defined at line(s) (1028) but is not used anywhere'
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
855faaa..a2e5436 5.0 -> 5.0
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
fa12395..5a1a4b9 master -> master
You need to log in
before you can comment on or make changes to this bug.
Description
•