React to the removal of non-Encoding Standard Mac encoders

RESOLVED FIXED in Thunderbird 37.0

Status

MailNews Core
Internationalization
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: hsivonen, Assigned: Magnus Melin)

Tracking

unspecified
Thunderbird 37.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Bug 997133 removed encoders for Mac encodings other than MacRoman and MacCyrillic. The decoders for the encodings whose encoders were removed are used by gfx for decoding the names of legacy fonts. The encodings aren't exposed to the Web.

comm-central should either
 1) Remove these encodings form charsetalias.properties and the like. (Preferred.)
OR
 2) Import the removed encodings into comm-central.
(Reporter)

Updated

3 years ago
Depends on: 997133
(Reporter)

Updated

3 years ago
Blocks: 1054354
(Reporter)

Comment 1

3 years ago
https://groups.google.com/forum/#!topic/mozilla.dev.apps.thunderbird/2P5kCJJS_WI
(Reporter)

Comment 2

3 years ago
(In reply to Henri Sivonen (:hsivonen) from comment #0)
>  1) Remove these encodings form charsetalias.properties and the like.

Oops. Keeping the aliases but marking these as notForOutgoing makes more sense.
(Assignee)

Comment 3

3 years ago
Created attachment 8526099 [details] [diff] [review]
bug1068505_react_removed_x-mac_encodings.patch

I see no reason to import the encoders.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #8526099 - Flags: review?(Pidgeot18)
Comment on attachment 8526099 [details] [diff] [review]
bug1068505_react_removed_x-mac_encodings.patch

Review of attachment 8526099 [details] [diff] [review]:
-----------------------------------------------------------------

So, I had a looksie. We don't use .notForOutgoing anywhere anymore--it used to be use in nsCharsetMenu, but bug 999881 replaced that use with CharsetMenu.jsm instead (since nsCharsetMenu died). As a result, the encoders that we support are hardcoded in that file, and as a few other lists in a few other files.

In short, this patch does nothing useful.
Attachment #8526099 - Flags: review?(Pidgeot18) → review-
(Assignee)

Comment 5

3 years ago
Created attachment 8530506 [details] [diff] [review]
bug1068505_react_removed_x-mac_encodings.patch

Since the mac decoders are still in place, I think there's not much to do, except to clean up the remaining unused notForOutgoing, notForBrowser and an outdated XXX comment.
Attachment #8526099 - Attachment is obsolete: true
Attachment #8530506 - Flags: review?
(Assignee)

Updated

3 years ago
Attachment #8530506 - Flags: review? → review?(Pidgeot18)
Attachment #8530506 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/comm-central/rev/ce58d0c3e55d -> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 37.0

Updated

3 years ago
No longer blocks: 1054354
You need to log in before you can comment on or make changes to this bug.