1068529 - Improve error messages when the log is not available

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Ed Morley [:emorley]]

Attachment: screenshot

For the red job here:
http://treeherder-dev.allizom.org/ui/#/jobs?repo=mozilla-central&revision=8252eae8278c&searchQuery=b2g_mozilla-central_emulator_dep

The job details panel does not link to the log viewer, nor the raw log. In addition, the failure summary tab says "Failure summary is empty". (See screenshot).

In TBPL we get "Log not available." in the failure summary, the brief log says "Log not available at URL <foo>", and the raw log link 404s.

If the log is non-existent, we should:
1) Say "Log not available" (or not found) rather than "Failure summary is empty" in the failure tab.
2) Still show the log viewer buttons, but perhaps disabled - like we do for parsing status "pending".
3) Show a parsing status of "failed" or similar (the parsing status line doesn't appear anywhere).

Comment 1

[Cameron Dawson [:camd]]

Attachment: with fixes

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/20c5cfd2f4d22620fe2bcc938e068738e70e9e6a
bug 1068529 - better msg when no logs

Comment 3

[Cameron Dawson [:camd]]

both buttons have the "you can't do this" mouse pointer.

fixed in:
https://github.com/mozilla/treeherder-ui/commit/20c5cfd2f4d22620fe2bcc938e068738e70e9e6a

Comment 4

[Ed Morley [:emorley]]

Thank you for this and the other related "Summary is empty" bugs - minor change but big difference to UX :-)

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5a74a323b1cae57d8184e3f55c765da04eaeb75d
bug 1068529 - better msg when no logs