1068544 - Support transceive function for nfcd

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Dimi Lee [:dimi]]

For proprietary tag information exchange, nfcd should support transceive function to transfer data

Comment 1

[Dimi Lee [:dimi]]

Attachment: WIP Patch v1

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

For MWC demo

Comment 3

[Dimi Lee [:dimi]]

Attachment: pull request to mozilla-b2g/platform_system_nfcd v2

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8539948 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd v2

see github.

Comment 5

[Dimi Lee [:dimi]]

(In reply to Yoshi Huang[:allstars.chh] from comment #4)
> Comment on attachment 8539948 [details] [review]
> pull request to mozilla-b2g/platform_system_nfcd v1
> 
> see github.

Hi Yoshi,
I have answered some questions in github, could you check it again ?
Thanks.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

replied

Comment 7

[Dimi Lee [:dimi]]

Comment on attachment 8539948 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd v2

- Address comment
- add notifyRfTimeout function
- change transceive function to use vector for both input and output parameter

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://github.com/mozilla-b2g/platform_system_nfcd/commit/f9c93ff3550ce324056d7c062e88fe45ca7dfd43

Comment 9

[Dimi Lee [:dimi]]

Comment on attachment 8539948 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd v2

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
NFC feature

User impact if declined: 
Third party Apps can not use NFC transceive function to get information
from tag

Testing completed: 
Manually.

Risk to taking this patch (and alternatives if risky): 
No.

String or UUID changes made by this patch:
No.

Comment 10

[Dimi Lee [:dimi]]

Attachment: pull request to mozilla-b2g/platform_system_nfcd 2.2

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

merged on nfcd v2.2 branch: https://github.com/mozilla-b2g/platform_system_nfcd/commit/66c2fd38d7a3fac74926e5922d6ed679ec121b2a