1068611 - [Contacts] [Regression] When importing contacts from Gmail the last imported date is not updated

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

STR:

Contacts -> Settings --> Import from Gmail --> SucessFully Import.

Actual: The last imported date is not refreshed

Expected: Date is refreshed

Note: The date is refreshed if the Contacts app is killed and then repopen

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Can you ask for a regression window?

Also knowing which version are affected will be nice.

Comment 2

[Cristian Rodriguez (:crdlc)]

Stealing here Jose ;) Gracias

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 4

[Jose Manuel Cantera]

Comment on attachment 8490792 [details]
Github pull request

r+ provided tests pass on TBPL

thanks!

Comment 5

[Jose Manuel Cantera]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #1)
> Can you ask for a regression window?
> 
> Also knowing which version are affected will be nice.

QA can confirm whether this reproduces on 2.1 or not

Comment 6

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/d32d647028a8eb5aed5583e9bab6ffcd63f38626

Comment 7

[Loli (:lolimartinezcr)]

Tested and *not* working, contacts are imported I can see last imported date *only* when user closes Contacts settings and accesses again.

Flame 
2.2
User
Gecko
Gaia

Comment 8

[Jose Manuel Cantera]

(In reply to Loli (:lolimartinezcr) from comment #7)
> Tested and *not* working, contacts are imported I can see last imported date
> *only* when user closes Contacts settings and accesses again.
> 
> Flame 
> 2.2
> User
> Gecko
> Gaia

Loli, are you sure you are testing with latest master build?

Comment 9

[Loli (:lolimartinezcr)]

(In reply to Jose Manuel Cantera from comment #8)
> (In reply to Loli (:lolimartinezcr) from comment #7)
> > Tested and *not* working, contacts are imported I can see last imported date
> > *only* when user closes Contacts settings and accesses again.
> > 
> > Flame 
> > 2.2
> > User
> > Gecko
> > Gaia
> 
> Loli, are you sure you are testing with latest master build?

Gecko cce3dff
Gaia 31434a3
Platform version: 35.0a1
Build ID: 20140918075610
Git commit: 879bd62d

Comment 10

[Cristian Rodriguez (:crdlc)]

My commit is more recent than 879bd62d

Comment 11

[Loli (:lolimartinezcr)]

Tested and working
Flame
2.2
Gecko-93e8d33
Gaia-dbc8904

Comment 12

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8490792 [details]
Github pull request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: wrong last date after importing from FB or Gmail
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): close to null
[String changes made]: no

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/14ced1c9868786bace6c7d845fdd0ec4bcdfdbce

Comment 14

[KTucker [:KTucker][Inactive 3/4/2016]]

Yeojin, can you verify this on 2.1?

Comment 15

[Yeojin Chung [:YeojinC]]

This issue is verified on 2.1. The date is updated correctly after importing Gmail contacts:

Flame 2.1 KitKat Base (319mb)(Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141002000202
Gaia: 94dcc25f2e34a4900ea58310c26be52bcb089161
Gecko: baaa0c3ab8fd
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0