Closed
Bug 1068618
Opened 10 years ago
Closed 10 years ago
[Loop] The shared link sms message is wrong
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
2.1 S6 (10oct)
People
(Reporter: mbarone976, Assigned: azasypkin)
References
Details
(Whiteboard: [sms-most-wanted][p=1])
Attachments
(2 files)
Captura de pantalla 2014-09-17 a la(s) 15.50.16.png
STR 1. On device A create Contact A with phone number (use a number not registered in Loop) 2. From Device A, try to establish a Loop connection with Contact A 2. When the fallback mechanism is shown, select the option message ACTUAL RESULT The sms message shows Let's instead of Let's (see attachment)
|
||
Comment 1•10 years ago
|
||
Arnau, can you handle this? Thanks a lot
Flags: needinfo?(rnowmrch)
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Whiteboard: [mobile app] → [mobile app][tef-triage]
Flags: needinfo?(rnowmrch)
QA Contact: rnowmrch
|
|
||
Updated•10 years ago
|
Assignee: nobody → rnowmrch
QA Contact: rnowmrch
Moving this bug to Messages app after talking to Oleg and Julien, this seems to be a double encoding in the Message activity.
Assignee: rnowmrch → nobody
Component: Gaia::Loop → Gaia::SMS
|
||
Comment 3•10 years ago
|
||
We need to check how activity are handled.
Whiteboard: [mobile app][tef-triage] → [mobile app][tef-triage][sms-most-wanted]
|
|
||
Updated•10 years ago
|
Whiteboard: [mobile app][tef-triage][sms-most-wanted] → [mobile app][sms-most-wanted]
|
|
||
Updated•10 years ago
|
Blocks: sms-sprint-2.1S6
Whiteboard: [mobile app][sms-most-wanted] → [mobile app][sms-most-wanted][p=1]
Target Milestone: --- → 2.1 S6 (10oct)
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•10 years ago
|
||
Hey Julien, Here is a small patch that fixes this issue + marionette test. Thanks!
Attachment #8501068 -
Flags: review?(felash)
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8501068 [details] [review] GitHub pull request URL please check if we have a test covering Compose.fromMessage escaping the body. If not, please add one. r=me with this
Attachment #8501068 -
Flags: review?(felash) → review+
|
|
||
Updated•10 years ago
|
Whiteboard: [mobile app][sms-most-wanted][p=1] → [sms-most-wanted][p=1]
|
|
Assignee | |
Comment 6•10 years ago
|
||
(In reply to Julien Wajsberg [:julienw] (PTO until 7th October, ask :steveck or :azasypkin for SMS stuff) from comment #5) > Comment on attachment 8501068 [details] [review] > GitHub pull request URL > > please check if we have a test covering Compose.fromMessage escaping the > body. If not, please add one. > > r=me with this Thanks for review! Added some tests for Compose.fromMessage, tests are green (except for some failing unrelated tests). Master: https://github.com/mozilla-b2g/gaia/commit/7b92615bdc97e5c675cd385ec68bc5e47e0c5288
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 7•10 years ago
|
||
Tested and working. Now sms is: Click on the link and answer the call! Flame eng v2.0 Gecko-dde9d61 Gaia-7b8df99 Loop version: 1.1 , aba155c
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•