1068644 - Firefox :: 'Clear all history' button is active when history is empty

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Screencasting, defect, P2)

Description

[Jenn Chaulk (:jchaulk)]

Roku Bug# 42283

Channel information: v 1.0 b 0

Platform/Firmware:
Giga – 5.5.410
Austin – 5.5.415
Jackson – 5.5.411
Tyler – 5.5.428
Sugarland – 5.5.2032
Paolo – 5.5.433
Liberty (Hisense) – 6.0.5029
Liberty (TCL) – 6.0.5029

Steps to reproduce:
1. Add the channel to Roku player.
2. Navigate to the channel and launch it.
3. Go to View recent history (History should be empty) -> Press * btn on remote -> Select 'Clear all history' btn

Expected Result: 'Clear all history' btn should not be active 

Actual Result: 'Clear all history' button is active and popup for deleting is appears, but history is empty

Attachment: https://roku.box.com/shared/static/8drafjaheaw1r5ggwatq.mp4

Reproducibility: always

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: no-clearhistory-whenempty

This was easy since we already added the code to make the menu items dynamic. If history is empty, we only need to check in the "default" items, the ones that are not removable.

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8493517 [details] [diff] [review]
no-clearhistory-whenempty

Review of attachment 8493517 [details] [diff] [review]:
-----------------------------------------------------------------

::: app/source/recentHistory.brs
@@ +84,3 @@
>                      if m.selectedItem.removable = false then
>                          actionText = ["Play", "-", "Clear all history"]
>                          actionMap = [0, 2]

I'd move this to an else statement, or better yet, restructure this:

actionText = ["Play"]
actionMap = [0]
if m.history[0].count() <> 0 then
    actionText.Append(["-", "Clear all history"])
    actionMap.Push(2)
end if

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Brian Nicholson (:bnicholson) from comment #2)
 
> I'd move this to an else statement, or better yet, restructure this:

Can't really use an else here because the only way for history to be empty is if we are on a built-in (removable == false) item.

> actionText = ["Play"]
> actionMap = [0]
> if m.history[0].count() <> 0 then
>     actionText.Append(["-", "Clear all history"])
>     actionMap.Push(2)
> end if

I almost did this, but with the ["Play", "-", "Remove", "Clear all history"] mode above, it just seemed more explicit to keep it as is.

https://github.com/mozilla/firefox-roku/commit/e1ceb05bd92e8e943202024edfaf744320aeb01f

Comment 4

[Flaviu Cos]

'Clear all history' button no longer appears if the history list is empty on Firefox Nightly for Roku v1.2.
Tested on Roku 2.

Comment 5

[Flaviu Cos]

Based on comment 4 will mark the bug as verified fixed.