1068703 - when in select mode emails list should be a multiselect listbox

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Marco Zehe (:MarcoZ)]

See also related bug 1068698. The easiest would be to have this thing a select size greater than 1, or the ARIA equivalent of that, and multiselect comes for free once the according attribute is set or removed. In the aria equivalent, much more heavy-lifting might be needed, and aria-multiselect must be used.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

Comment 2

[James Burke [:jrburke]]

Comment on attachment 8557310 [details] [review]
Github pull request.

Looks good, I just have one review comment about resetting state for both editMode and non-editMode cases, once that is complete follow up review should be straightforward.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8557310 [details] [review]
Github pull request.

Fixed up the setMode based on your comments, thanks!

Comment 4

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/43a2ad7a5660b6edf61ed528b1151c7a811f8a92

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8557310 [details] [review]
Github pull request.

[Approval Request Comment] This pull request improves accessibility of the edit mode in message list view.
[Bug caused by] (feature/regressing bug #): improvement, not a bug
[User impact] if declined: Screen reader users will not be able to use the edit mode efficiently.
[Testing completed]: unit tests + on device testing
[Risk to taking this patch] (and alternatives if risky): Fairly low
[String changes made]: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/ec84d177dbbd28562f9099968d24d1525d81fc75