Closed Bug 1068716 Opened 10 years ago Closed 9 years ago

email entry: improve overall accessibility

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::E-Mail
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S4 (23jan)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: MarcoZ, Assigned: yzen)

References

Details

(Keywords: access, Whiteboard: [b2ga11y p=1])

Attachments

(1 file)

Github pull request.
46 bytes, text/x-github-pull-request
jrburke
: review+
bajaj
: approval-gaia-v2.2+
Details | Review 
Once added, touching, then double-tapping a recipient doesn't do anything.
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Attached file Github pull request. — 
This one is ready for review but depends on bug 1068712 (e.g. contains an extra commit).
Attachment #8552230 - Flags: review?(jrburke)
The issues that email entry has that are being addressed:
* better labeling of all controls
* better taget sizes
* improved accessibility of the bottom and header panels.
Summary: email entry: recipients aren't operable with the screen reader → email entry: improve overall accessibility
Comment on attachment 8552230 [details] [review]
Github pull request.

r+ for the changeset related to this bug, and providing the unit test passes on Treeherder (it seems to have died for the initial run on this pull request).
Attachment #8552230 - Flags: review?(jrburke) → review+
https://github.com/mozilla-b2g/gaia/commit/c322468a7fc9e12a59774d34147f9c1754f1bf30
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8552230 [details] [review]
Github pull request.

[Approval Request Comment] This pull request fixes accessibility for email entry screen.
[Bug caused by] (feature/regressing bug #): Improvement
[User impact] if declined: Screen reader users will not be able to use the email entry screen in Email app
[Testing completed]: Added unit tests for changes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: https://github.com/mozilla-b2g/gaia/pull/27548/files#diff-4
Attachment #8552230 - Flags: approval-gaia-v2.2?
Requesting on-device testing for this before uplifting .
Flags: needinfo?(yzenevich)
I did all my development/testing for this bug on device, does that suffice?
Flags: needinfo?(yzenevich)
Attachment #8552230 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: