Closed
Bug 1068814
Opened 10 years ago
Closed 10 years ago
[Contacts] Setting ICE contact with only a phone number does not show on ICE contacts settings screen
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:2.1+, b2g-v2.1 verified, b2g-v2.2 verified)
People
(Reporter: bzumwalt, Assigned: jmcf)
References
()
Details
(Whiteboard: [2.1-flame-test-run-2])
Attachments
(2 files)
1.17 KB,
text/plain
|
Details | |
191 bytes,
text/html
|
arcturus
:
review+
fabrice
:
approval-gaia-v2.1+
|
Details |
Description: When user is setting ICE contacts, selecting a contact with only a phone number (no name or other fields filled out) still shows a blank drop-down instead of showing phone number in place of blank box. When user chooses contact with name the name fills the dropdown box. Even if user chooses a contact with only a phone number, the contact will be added to ICE list and is visible in ICE section of contacts list. Repro Steps: 1) Update a Flame device to BuildID: 20140917000205 2) Launch contacts (have contact with only phone number filled out) 3) Select gear icon to enter app settings 4) Press "Set ICE Contacts" 5) Toggle ICE Contact 1 switch 6) Tap dropdown box and select contact with only phone number Actual: After selecting number box remains blank as though user had not selected a contact. Expected: After selecting number box shows phone number indicating that user has selected a contact. Environmental Variables: Device: Flame 2.1 (319mb) BuildID: 20140917000205 Gaia: 47939f4c41d0c941e5047e5d1af74a79b7d8e0d5 Gecko: e20869e87e23 Version: 34.0a2 (2.1) Firmware: V123 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Repro frequency: 3/3, 100% Link to failed test case: https://moztrap.mozilla.org/manage/case/14205/ See attached: Youtube video clip & logcat Youtube video link: http://youtu.be/rSKwc9j0vq8
Reporter | ||
Comment 1•10 years ago
|
||
Issue DOES occur on Flame 2.2 (319mb), OpenC 2.2, Flame 2.1 (512mb), and OpenC 2.1 Flame 2.2 (319mb) Device: Flame 2.2 BuildID: 20140917040204 Gaia: 50666fa8bbbf3d346faff24f92ad8140a44a49d0 Gecko: 8252eae8278c Version: 35.0a1 (2.2) Firmware: V123 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 Open C 2.2 Device: Open_C 2.2 BuildID: 20140917040204 Gaia: 50666fa8bbbf3d346faff24f92ad8140a44a49d0 Gecko: 8252eae8278c Version: 35.0a1 (2.2) Firmware: P821A10v1.0.0B06_LOG_DL User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 Flame 2.1 (512 mb) Device: Flame 2.1 BuildID: 20140917000205 Gaia: 47939f4c41d0c941e5047e5d1af74a79b7d8e0d5 Gecko: e20869e87e23 Version: 34.0a2 (2.1) Firmware: V123 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Open C 2.1 Device: Open_C 2.1 BuildID: 20140917000205 Gaia: 47939f4c41d0c941e5047e5d1af74a79b7d8e0d5 Gecko: e20869e87e23 Version: 34.0a2 (2.1) Firmware: P821A10v1.0.0B06_LOG_DL User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Actual Results: After selecting number box remains blank as though user had not selected a contact. ICE functionality not present on builds prior to 2.1, unable to test
Comment 2•10 years ago
|
||
Johan, can you weigh in on whether or not this is a severe enough issue to block on?
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker) → needinfo?(jlorenzo)
Comment 3•10 years ago
|
||
Johan is out until Sept 26th, so I'm switching needinfo to Eric here.
Flags: needinfo?(jlorenzo) → needinfo?(echang)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][lead-review+]
Comment 4•10 years ago
|
||
[Blocking Requested - why for this release]: Major issue in new feature
blocking-b2g: --- → 2.1?
Flags: needinfo?(echang)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jmcf
Comment 7•10 years ago
|
||
Comment on attachment 8491408 [details]
24171.html
Awesome work here, don't have anything else to add.
Thanks!
Attachment #8491408 -
Flags: review?(francisco) → review+
Assignee | ||
Comment 8•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/d2c32c964016d4b28c5cc2aa42102a806c72cb5f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8491408 [details]
24171.html
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): ICE contacts New functionality
[User impact] if declined: High, the user cannot see information about her ICE Contacts
[Testing completed]: Yes. Patch includes unit tests as well.
[Risk to taking this patch] (and alternatives if risky): Low-Risk
[String changes made]:
Attachment #8491408 -
Flags: approval-gaia-v2.1?
Updated•10 years ago
|
Target Milestone: --- → 2.1 S5 (26sep)
Updated•10 years ago
|
Attachment #8491408 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Comment 10•10 years ago
|
||
v2.1: https://github.com/mozilla-b2g/gaia/commit/20eba052fc5a1557d9ae258fddb2fcdd4f4faf8e
Comment 11•10 years ago
|
||
This issue is verified fixed for the latest 2.2 Flame build: Environmental Variables: ---------------------------------------- Device: Flame 2.2 Master BuildID: 20141012040203 Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab Gecko: 44168a7af20d Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf Version: 35.0a1 (2.2 Master) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0 Environmental Variables: ---------------------------------------- Device: Flame 2.1 BuildID: 20141012001201 Gaia: d18e130216cd3960cd327179364d9f71e42debda Gecko: 610ee0e6a776 Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf Version: 34.0a2 (2.1) Firmware: V180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 User can now see contacts containing only a phone number when selecting ICE contact.
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+][lead-review+] → [QAnalyst-Triage?][lead-review+]
Flags: needinfo?(ktucker)
Updated•10 years ago
|
QA Whiteboard: [QAnalyst-Triage?][lead-review+] → [QAnalyst-Triage+][lead-review+]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•