1068814 - [Contacts] Setting ICE contact with only a phone number does not show on ICE contacts settings screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Description:
When user is setting ICE contacts, selecting a contact with only a phone number (no name or other fields filled out) still shows a blank drop-down instead of showing phone number in place of blank box. When user chooses contact with name the name fills the dropdown box.

Even if user chooses a contact with only a phone number, the contact will be added to ICE list and is visible in ICE section of contacts list.
   
Repro Steps:
1) Update a Flame device to BuildID: 20140917000205
2) Launch contacts (have contact with only phone number filled out)
3) Select gear icon to enter app settings
4) Press "Set ICE Contacts"
5) Toggle ICE Contact 1 switch
6) Tap dropdown box and select contact with only phone number
  
Actual:
After selecting number box remains blank as though user had not selected a contact.
  
Expected: 
After selecting number box shows phone number indicating that user has selected a contact.
  
Environmental Variables:
Device: Flame 2.1 (319mb)
BuildID: 20140917000205
Gaia: 47939f4c41d0c941e5047e5d1af74a79b7d8e0d5
Gecko: e20869e87e23
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Repro frequency: 3/3, 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/14205/
See attached: Youtube video clip & logcat
Youtube video link: http://youtu.be/rSKwc9j0vq8

Comment 1

[Brogan Zumwalt [Inactive]]

Issue DOES occur on Flame 2.2 (319mb), OpenC 2.2, Flame 2.1 (512mb), and OpenC 2.1

Flame 2.2 (319mb)
Device: Flame 2.2
BuildID: 20140917040204
Gaia: 50666fa8bbbf3d346faff24f92ad8140a44a49d0
Gecko: 8252eae8278c
Version: 35.0a1 (2.2)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Open C 2.2
Device: Open_C 2.2
BuildID: 20140917040204
Gaia: 50666fa8bbbf3d346faff24f92ad8140a44a49d0
Gecko: 8252eae8278c
Version: 35.0a1 (2.2)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 (512 mb)
Device: Flame 2.1
BuildID: 20140917000205
Gaia: 47939f4c41d0c941e5047e5d1af74a79b7d8e0d5
Gecko: e20869e87e23
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Open C 2.1
Device: Open_C 2.1
BuildID: 20140917000205
Gaia: 47939f4c41d0c941e5047e5d1af74a79b7d8e0d5
Gecko: e20869e87e23
Version: 34.0a2 (2.1)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Actual Results: After selecting number box remains blank as though user had not selected a contact.


ICE functionality not present on builds prior to 2.1, unable to test

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Johan, can you weigh in on whether or not this is a severe enough issue to block on?

Comment 3

[Jason Smith [:jsmith]]

Johan is out until Sept 26th, so I'm switching needinfo to Eric here.

Comment 4

[Eric Chang [:ericcc] [:echang]]

[Blocking Requested - why for this release]: Major issue in new feature

Comment 5

[Maria Angeles Oteo (:oteo)]

triage: 2.1+ bug

Comment 6

[Jose Manuel Cantera]

Attachment: 24171.html

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8491408 [details]
24171.html

Awesome work here, don't have anything else to add.

Thanks!

Comment 8

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/d2c32c964016d4b28c5cc2aa42102a806c72cb5f

Comment 9

[Jose Manuel Cantera]

Comment on attachment 8491408 [details]
24171.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): ICE contacts New functionality
[User impact] if declined: High, the user cannot see information about her ICE Contacts
[Testing completed]: Yes. Patch includes unit tests as well. 
[Risk to taking this patch] (and alternatives if risky): Low-Risk
[String changes made]:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/20eba052fc5a1557d9ae258fddb2fcdd4f4faf8e

Comment 11

[Roland Kunkel [:RolandK]]

This issue is verified fixed for the latest 2.2 Flame build:

Environmental Variables:
----------------------------------------
Device: Flame 2.2 Master
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Environmental Variables:
----------------------------------------
Device: Flame 2.1
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

User can now see contacts containing only a phone number when selecting  ICE contact.