Visual feed-back should be provided to the search suggestion list item

VERIFIED FIXED in Firefox 33

Status

()

defect
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: alice0775, Assigned: adw)

Tracking

35 Branch
Firefox 35
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox33+ verified, firefox34+ verified, firefox35+ verified)

Details

Attachments

(1 attachment)

Steps To Reproduce:
1. Open about:home or about:newtab page
2. Type any words (e.g., mozilla )
3. Mouse over search suggestion list item

Actual Results:
No visual feed-back 

Expected Results:
Mouse hover item should be highlighted
Posted patch patchSplinter Review
Sigh.  Highlight/select rows on hover, just don't copy them into the input.
Assignee: nobody → adw
Status: NEW → ASSIGNED
Attachment #8491012 - Flags: review?(MattN+bmo)
[Tracking Requested - why for this release]:

Bug 1060888 was supposed to fix this but didn't really.  We were tracking that bug so I think we should track this one too.
Comment on attachment 8491012 [details] [diff] [review]
patch

Review of attachment 8491012 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8491012 - Flags: review?(MattN+bmo) → review+
Thanks Matt.  fx-team's closed, marking checkin-needed.
OS: Windows 7 → All
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/37f902fba2de
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Comment on attachment 8491012 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1060888
[User impact if declined]: this bug
[Describe test coverage new/current, TBPL]: automated and manual testing
[Risks and why]: low risk, only changes mouseover behavior of about:home/newtab suggestions
[String/UUID change made/needed]: none
Attachment #8491012 - Flags: approval-mozilla-beta?
Attachment #8491012 - Flags: approval-mozilla-aurora?
Attachment #8491012 - Flags: approval-mozilla-beta?
Attachment #8491012 - Flags: approval-mozilla-beta+
Attachment #8491012 - Flags: approval-mozilla-aurora?
Attachment #8491012 - Flags: approval-mozilla-aurora+
Flags: qe-verify+
QA Contact: petruta.rasa
Verified on all builds, all platforms while checking bug 1060888.
You need to log in before you can comment on or make changes to this bug.