1068852 - Visual feed-back should be provided to the search suggestion list item

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Alice0775 White]

Steps To Reproduce:
1. Open about:home or about:newtab page
2. Type any words (e.g., mozilla )
3. Mouse over search suggestion list item

Actual Results:
No visual feed-back 

Expected Results:
Mouse hover item should be highlighted

Comment 1

[Drew Willcoxon :adw]

Attachment: patch

Sigh.  Highlight/select rows on hover, just don't copy them into the input.

Comment 2

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]:

Bug 1060888 was supposed to fix this but didn't really.  We were tracking that bug so I think we should track this one too.

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8491012 [details] [diff] [review]
patch

Review of attachment 8491012 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 4

[Drew Willcoxon :adw]

Thanks Matt.  fx-team's closed, marking checkin-needed.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/37f902fba2de

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/37f902fba2de

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 8491012 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1060888
[User impact if declined]: this bug
[Describe test coverage new/current, TBPL]: automated and manual testing
[Risks and why]: low risk, only changes mouseover behavior of about:home/newtab suggestions
[String/UUID change made/needed]: none

Comment 8

[Drew Willcoxon :adw]

https://hg.mozilla.org/releases/mozilla-aurora/rev/692378481851
https://hg.mozilla.org/releases/mozilla-beta/rev/a34329afda87

Comment 9

[Petruta Horea [:phorea], Desktop Test Engineering (back on Sep 5th)]

Verified on all builds, all platforms while checking bug 1060888.