1068970 - MediaDecoderStateMachine::SendStreamAudio() is incorrectly calling UsecsToFrames

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

MediaDecoderStateMachine::SendStreamAudio() is incorrectly calling UsecsToFrames

http://mxr.mozilla.org/mozilla-central/source/content/media/MediaDecoderStateMachine.cpp#303

UsecsToFrames is as defined as:

UsecsToFrames(int64_t aUsecs, uint32_t aRate)

But we call it as:

   CheckedInt64 audioWrittenOffset = UsecsToFrames(mInfo.mAudio.mRate,
       aStream->mInitialTime + mStartTime) + aStream->mAudioFramesWritten;

rate/time needs to be swapped here.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Ensure MediaDecoderStateMachine::SendStreamAudio() gets the order of arguments to UsecsToFrames correct...

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8491090 [details] [diff] [review]
Patch

Review of attachment 8491090 [details] [diff] [review]:
-----------------------------------------------------------------

great catch!

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Credit goes to Sotaro for spotting this!

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9362521b7f7a

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

It looks like this patch never made itself to Central...

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

I never had the time to get it green. You're welcome to take it off my hands!

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1068970_fix-v2.patch

Rebase. https://treeherder.mozilla.org/#/jobs?repo=try&revision=9318f4583748

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8628176 [details] [diff] [review]
1068970_fix-v2.patch

Try looks green after rebase. https://treeherder.mozilla.org/#/jobs?repo=try&revision=9318f4583748

Carry r+ from roc.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c124eec5ebd

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3c124eec5ebd