1068977 - Annotate toolkit/components/parentalcontrols as FAIL_ON_WARNINGS

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Looks like toolkit/components/parentalcontrols is build-warning-free, with bug 1010103's patch.

Filing this bug on annotating it as such.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

I verified locally that this is effective (i.e. it turns bug 1010103's warning into an error for me).

Here's a Try push with this patch & that bug's patch applied, to be sure we don't hit any other warnings, after that warning is fixed: https://tbpl.mozilla.org/?tree=Try&rev=73259b5e4bed

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8491099 [details] [diff] [review]
fix v1

Kicking this over to a different toolkit peer, since doug seems to be pretty busy.

(IIRC, I'd initially tagged Doug since he's the main person to have touched this directory, but I think anyone who reviews toolkit code can sign off on this; really just needs a rubber-stamp.)

Comment 3

[Daniel Holbert [:dholbert]]

Thanks! Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/d8b5efe0c3dd

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d8b5efe0c3dd