Closed
Bug 1069013
Opened 10 years ago
Closed 9 years ago
Edit view: Crop options and filter options are not labeled
Categories
(Firefox OS Graveyard :: Gaia::Gallery, defect)
Tracking
(b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S5 (6feb)
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Keywords: access, Whiteboard: [b2ga11y p=1])
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
pdahiya
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
They could also probably use a different role, like radio, since the are each mutually exclusive.
Assignee | ||
Updated•10 years ago
|
Component: Gaia → Gaia::Gallery
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8553461 -
Flags: review?(pdahiya)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → eitan
Comment 2•9 years ago
|
||
Comment on attachment 8553461 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27616 Hi Eitan Patch looks good and has r+. A nit noted in github and with that updated and gaia-try green its good to land. Thanks!
Updated•9 years ago
|
Attachment #8553461 -
Flags: review?(pdahiya) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/e90469b38d08cd8060c17f4cbaec29ede9e539c7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8553461 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27616 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: Screen reader users will not have a correct view of the state of the crop/effect buttons and won't know which one is toggled. [Testing completed]: Manual. [Risk to taking this patch] (and alternatives if risky): Low. [String changes made]: Added labels to crop/effect buttons.
Attachment #8553461 -
Flags: approval-gaia-v2.2?
Updated•9 years ago
|
Attachment #8553461 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 5•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/85a8e2960949b3955971be7952903d679ae46b24
You need to log in
before you can comment on or make changes to this bug.
Description
•