Closed Bug 1069013 Opened 10 years ago Closed 9 years ago

Edit view: Crop options and filter options are not labeled

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

RESOLVED FIXED
2.2 S5 (6feb)
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

(Keywords: access, Whiteboard: [b2ga11y p=1])

Attachments

(1 file)

They could also probably use a different role, like radio, since the are each mutually exclusive.
Component: Gaia → Gaia::Gallery
Assignee: nobody → eitan
Comment on attachment 8553461 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27616

Hi Eitan 
Patch looks good and has r+. A nit noted in github and with that updated and gaia-try green its good to land. Thanks!
Attachment #8553461 - Flags: review?(pdahiya) → review+
https://github.com/mozilla-b2g/gaia/commit/e90469b38d08cd8060c17f4cbaec29ede9e539c7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8553461 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27616

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Screen reader users will not have a correct view of the state of the crop/effect buttons and won't know which one is toggled.
[Testing completed]: Manual.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: Added labels to crop/effect buttons.
Attachment #8553461 - Flags: approval-gaia-v2.2?
Attachment #8553461 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: