Fix -Wunused-const-variable warnings in content/xul

RESOLVED FIXED in Firefox 35

Status

()

Product:
Core
Component:
General
Type:
defect
Status:
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Blocks 1 bug)

Version:
unspecified
Target:
mozilla35
Platform:
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox34 wontfix, firefox35 fixed)

Details

Attachments

(1 attachment)

fix-xul-warnings.patch
1.79 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Assignee

Description

•
5 years ago 
clang only reports these unused warnings for non-unified builds, presumably because it has less to think about. The default non-unified mozconfig files do not include --enable-warnings-as-errors, so these warnings are not flagged on TBPL's non-unified builds.

Also remove a bogus "Note the ALPHABETICAL ORDERING" from hg@1. :)

content/xul/document/src/XULDocument.cpp:126:16 [-Wunused-const-variable] unused variable 'kMaxAttrNameLength'
content/xul/document/src/XULDocument.cpp:127:16 [-Wunused-const-variable] unused variable 'kMaxAttributeLength'
Attachment #8491241 - Flags: review?(bzbarsky)

Comment 1

•
5 years ago 
Comment on attachment 8491241 [details] [diff] [review]
fix-xul-warnings.patch

r=me
Attachment #8491241 - Flags: review?(bzbarsky) → review+
Depends on: 559505

Comment 3

•
5 years ago 
This did land on mozilla-central, though the bug didn't get marked. Sorry for any confusion.
https://hg.mozilla.org/mozilla-central/rev/507bdbd98fae
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.