Closed
Bug 1069169
Opened 10 years ago
Closed 10 years ago
[callscreen] unittest call_sccreen_test.js incorrect using assert.include for testing existing object propertyng
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sv99, Assigned: sv99)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20140917114326
Steps to reproduce:
```javascript
746: assert.include(bannerClass, 'visible');
```
assert.include - test inclusion of an object in another. Works for strings and Arrays, for other do nothing!!
later testing this property
```javascript
test('should hide the banner', function() {
assert.isFalse(bannerClass.contains('visible'));
});
```
Attachment #8491311 -
Flags: review?(felash)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8491311 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24162 Redirecting to a peer for the Dialer
Attachment #8491311 -
Flags: review?(felash) → review?(anthony)
|
||
Updated•10 years ago
|
Assignee: nobody → sv99
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8491311 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24162 Ah thanks for this!
Attachment #8491311 -
Flags: review?(anthony) → review+
|
|
||
Comment 4•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/342b03a2359d7e5b01578d6068d242ccea98ef62
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•