106918 - Mover handling is borked on move.pl.

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P3)

Description

[Matthew Tuck [:CodeMachine]]

When I enter the following for movers:

[e-mail], [e-mail]

The code detects [e-mail] is a mover on bug_form.pl, but not move.pl.  This is
because:

my $movers = Param("movers");
$movers =~ s/\w?,\w?/|/g;
$movers =~ s/@/\@/g;

Those \w should be \s.

There should also be a routine that does this for both sides in globals.pl.

For both, that should probably be (\s)* too, not (\s)?.

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch v1

Fixes both move.pl and Bug.pm so either format of lists of movers works

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 112318 [details] [diff] [review]
Patch v1

This is already applied on both mothra and bugscape (had to because someone
needed to move a bug).	Seems to work so far, but I'd appreciate a sanitycheck.

Comment 3

[Dave Miller [:justdave]]

Attachment: Patch v2

Take 2: move.pl defines user.login for show.xml.tmpl now.  Moving actually
works now. :)

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 112322 [details] [diff] [review]
Patch v2

This does solve the problem, and for me it also made fixed bug_form.pl to show
the "move" button.

Comment 5

[Dave Miller [:justdave]]

Checking in Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.28; previous revision: 1.27
done
Checking in move.pl;
/cvsroot/mozilla/webtools/bugzilla/move.pl,v  <--  move.pl
new revision: 1.17; previous revision: 1.16
done

Comment 6

[Dave Miller [:justdave]]

*** Bug 256135 has been marked as a duplicate of this bug. ***