1069182 - Unable to exit out of Guest Browsing via system notification

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[u421692]

Attachment: logs

Environment:
Device: Samsung Galaxy Nexus(Android 4.2.1)
Build: Nightly 35.0a1 (2014-09-17)

Steps to reproduce:
1. Open Menu->Tools->New Guest Session
2. From Android notification bar, tap on Guest browsing android notification

Expected result:
Guest session is closed

Actual result:
Tapping on Guest browsing android notification does not exit guest session
(see attached logs)

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Err. I must have moved this code at some point. If Gecko was running our onNewIntent code would never be hit because !Intent.ACTION_MAIN.equals(action) is always true. I also made this an implicit intent to avoid confusion between different releases.

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8491901 [details] [diff] [review]
Patch

Review of attachment 8491901 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/BrowserApp.java
@@ +2935,5 @@
>          if (!mInitialized) {
>              return;
>          }
>  
>          // Only solicit feedback when the app has been launched from the icon shortcut.

Nit: Move comment back down to keep it with the ACTION_MAIN return.

Comment 3

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/dad1d0099623

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/dad1d0099623

Comment 5

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in
Build: Firefox for Android 35.0a1 (2014-09-25)
Devices: 
Asus Transformer Pad TF300T (Android 4.2.1)
Nexus 4 (Android 4.4.4)