[NFC] NfcManager should not expose sessionToken to regular webapps

RESOLVED FIXED in Firefox OS v2.2

Status

Firefox OS
NFC
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tauzen, Assigned: tauzen)

Tracking

unspecified
2.1 S5 (26sep)
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.2 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
NfcManager fires mostly NDEF related activities which can be handled by regular web apps. Since Bug 1046554 landed, sessionToken is not needed to obtain NFCPeer/NFCTag by regular web apps. Bug 1054139 will require "nfc-manager" permissions to use getNFCPeer/getNFCTag, so essentially sessionToken will not mean anything for web apps and should not be passed to the activity.
(Assignee)

Updated

4 years ago
Assignee: nobody → kmioduszewski
Blocks: 963533, 933640
Depends on: 1054139
(Assignee)

Comment 1

4 years ago
Created attachment 8492936 [details] [review]
pull-request-1069188.txt
Attachment #8492936 - Flags: review?(gweng)
Comment on attachment 8492936 [details] [review]
pull-request-1069188.txt

Two nits. Please fix them and land it, thanks.
Attachment #8492936 - Flags: review?(gweng) → review+
(Assignee)

Comment 3

4 years ago
Thanks for the review! I fixed the nits and try is green once again.
Keywords: checkin-needed
(Assignee)

Comment 4

4 years ago
Correction, Gij failed on unrelated test.
Master: https://github.com/mozilla-b2g/gaia/commit/38a993ba95a5829bc7926e9424bb3a8a7b14a0f2
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.2: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in before you can comment on or make changes to this bug.