1069197 - Month view: grid items are not operable with the screen reader

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Marco Zehe (:MarcoZ)]

Focusing, then double-tapping items in the grid does not do anything when the screen reader is on.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Also screen reader should support 2 finger swipe left and right to work like the sideswiping with single finger without it (to switch months).

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8501717 [details] [review]
Github pull request.

The code generally looks fine to me, but I would like either Gareth or Miller to take a look if possible.

Comment 4

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8501717 [details] [review]
Github pull request.

I added a few comments on Github, we will probably need to wait modularization work to land before we merge this patch. (Bug 1027707)

Comment 5

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8501717 [details] [review]
Github pull request.

code changes looks good to me, tests makes sense and app still works like before; only thing that I think needs to change is to use the ES6 string templates (Bug 1055432).

PS: I don't know how to operate the screen reader on the device properly, took me forever to disable it :P only thing that I "heard" was "16 button, 2 events" and "1 button, other month". I was not able to test the "swipe" because I don't know how to trigger it.

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Miller Medeiros [:millermedeiros] from comment #5)
> Comment on attachment 8501717 [details] [review]
> Github pull request.
> 
> code changes looks good to me, tests makes sense and app still works like
> before; only thing that I think needs to change is to use the ES6 string
> templates (Bug 1055432).
> 
> PS: I don't know how to operate the screen reader on the device properly,
> took me forever to disable it :P only thing that I "heard" was "16 button, 2
> events" and "1 button, other month". I was not able to test the "swipe"
> because I don't know how to trigger it.

Hopefully this can help getting to know the screen reader better: https://wiki.mozilla.org/Accessibility/Mobile/ScreenReader

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Miller Medeiros [:millermedeiros] from comment #5)
> Comment on attachment 8501717 [details] [review]
> Github pull request.
> 
> code changes looks good to me, tests makes sense and app still works like
> before; only thing that I think needs to change is to use the ES6 string
> templates (Bug 1055432).
> 
> PS: I don't know how to operate the screen reader on the device properly,
> took me forever to disable it :P only thing that I "heard" was "16 button, 2
> events" and "1 button, other month". 

Yes the idea is that when the user first steps into the month grid, they will hear what month year it is for (e.g. the header heading) , all consequent moves within the grid will result in only button name announced for reduced verbosity.

> I was not able to test the "swipe" because I don't know how to trigger it.

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

https://github.com/mozilla-b2g/gaia/commit/f6a402ad6179674b16f1e7204800b6637f97ed8c