If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Several views are not exclusively visible to screen reader.

RESOLVED FIXED

Status

Firefox OS
Gaia::Calendar
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: MarcoZ, Assigned: yzen)

Tracking

(Blocks: 1 bug, {access})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [b2ga11y p=1])

Attachments

(1 attachment, 2 obsolete attachments)

46 bytes, text/x-github-pull-request
millermedeiros
: review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
Other opaque or otherwise hidden items of the calendar are as well when the Add Event screen is active.
I missed the conversation earlier today on IRC between :gaye and :yzen. But I think we can add [aria-hidden] to any view that is not the "active" one (even if `clear === false`)[1]

that will probably be easier than adding logic to the AbstractView (some views doesn't inherit from it anymore - like the WeekView and very soon the DayView as well). And also avoid adding custom logic to the SettingsView.

 [1] https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/js/router.js#L145-L147
Flags: needinfo?(yzenevich)
(Assignee)

Comment 2

3 years ago
(In reply to Miller Medeiros [:millermedeiros] from comment #1)
> I missed the conversation earlier today on IRC between :gaye and :yzen. But
> I think we can add [aria-hidden] to any view that is not the "active" one
> (even if `clear === false`)[1]
> 
> that will probably be easier than adding logic to the AbstractView (some
> views doesn't inherit from it anymore - like the WeekView and very soon the
> DayView as well). And also avoid adding custom logic to the SettingsView.
> 
>  [1]
> https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/js/router.
> js#L145-L147

Thanks I ll have something soon to take a look.
Flags: needinfo?(yzenevich)
(Assignee)

Updated

3 years ago
Depends on: 1069209
(Assignee)

Comment 3

3 years ago
The views include: add event, settings, advanced settings, etc.
Summary: Add Event view is not exclusively visible to screen reader → Several views are not exclusively visible to screen reader.
(Assignee)

Comment 4

3 years ago
(In reply to Miller Medeiros [:millermedeiros] from comment #1)
> I missed the conversation earlier today on IRC between :gaye and :yzen. But
> I think we can add [aria-hidden] to any view that is not the "active" one
> (even if `clear === false`)[1]
> 
> that will probably be easier than adding logic to the AbstractView (some
> views doesn't inherit from it anymore - like the WeekView and very soon the
> DayView as well). And also avoid adding custom logic to the SettingsView.
> 
>  [1]
> https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/js/router.
> js#L145-L147

After more investigation it turns out that it is not possible to just make changes within the router. The reason is that some time views do not include things like the header and tabs. Which means I need to handle the screen reader visibility of the whole #time-views block when settings are open.
(Assignee)

Comment 5

3 years ago
Created attachment 8507010 [details]
Github changes.

I will issue a pull request once bug 1069209 is merged. Right it's just a commit with all necessary changes for this bug. Hopefully that is ok.
Attachment #8507010 - Flags: review?(miller)
(Assignee)

Comment 6

3 years ago
Created attachment 8507045 [details]
Github changes.

rebased
Attachment #8507010 - Attachment is obsolete: true
Attachment #8507010 - Flags: review?(miller)
Attachment #8507045 - Flags: review?(mmedeiros)
(Assignee)

Comment 7

3 years ago
Created attachment 8507124 [details] [review]
Github pull request.
Attachment #8507045 - Attachment is obsolete: true
Attachment #8507045 - Flags: review?(mmedeiros)
Attachment #8507124 - Flags: review?(mmedeiros)
(Assignee)

Updated

3 years ago
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Blocks: 1084551
Comment on attachment 8507124 [details] [review]
Github pull request.

just a small comment about the "body[data-path^='/settings'] #settings" CSS rules and the "visibility test". otherwise it looks good to me. thanks!
Attachment #8507124 - Flags: review?(mmedeiros) → review+
(Assignee)

Comment 9

3 years ago
https://github.com/mozilla-b2g/gaia/commit/d7d34643df4e602bdaaacdd1b80eee945cb5e2ec
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.