Closed Bug 1069227 Opened 11 years ago Closed 11 years ago

[Loop] Make sure that we recover from an expired token situation

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ferjm, Assigned: jaoo)

References

Details

(Whiteboard: [mobile app][blocking][loop in 1.1])

Attachments

(2 files)

Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/206
61 bytes, text/x-github-pull-request
ferjm
: review+
Details | Review
Wireframe+Strings_1069227.pdf
41.22 KB, application/pdf
Details
No description provided.
Assignee: nobody → josea.olivera
Status: NEW → ASSIGNED
Attachment #8506005 - Flags: review?(ferjmoreno)
I copy what Fernando suggested in the review. "We probably need a different string for this. Something like "Your account session expired. Please, login again" or whatever." So, that would be possible to have a new string then?
Flags: needinfo?(monica.meika)
Comment on attachment 8506005 [details] [review] Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/206 Thanks jaoo. I added a few comments to the PR.
Attachment #8506005 - Flags: review?(ferjmoreno)
Setting this as a blocker. We cannot ship without this. Users may be stuck with a non functional app if we don't have a mechanism to recover from expired sessions.
Severity: normal → blocker
Hey. Attached the PDF with the Wireframe+Strings. Thank's.
Flags: needinfo?(monica.meika)
Attachment #8506005 - Flags: review?(ferjmoreno)
Comment on attachment 8506005 [details] [review] Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/206 r=me with the comments addressed and Borja blessing
Attachment #8506005 - Flags: review?(ferjmoreno)
Attachment #8506005 - Flags: review?(borja.bugzilla)
Attachment #8506005 - Flags: review+
Few comments to address, but the code looks great! Thanks! :)
Landed on master branch at: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/89d0c8921c26ede101f4945cdda1ac9436b0a9b5
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [mobile app][blocking][need 1.1 uplift][master]
Whiteboard: [mobile app][blocking][need 1.1 uplift][master] → [mobile app][blocking][loop not in 1.1]
Whiteboard: [mobile app][blocking][loop not in 1.1] → [mobile app][blocking][loop approved for 1.1]
Whiteboard: [mobile app][blocking][loop approved for 1.1] → [mobile app][blocking][loop in 1.1]
Attachment #8506005 - Flags: review?(borja.bugzilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: