1069236 - [Dialer][Call Screen] Callscreen Icon on notification becomes extra large

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: 2014-09-18-08-49-41.png

### STR
1. Have an active call.
2. Leave call screen to another apps or home.
3. Pull down notification area

### Actual
Callscreen Icon on notification becomes extra large 

### Version
Gaia      379e68fe729a684fa2fcddb30ea1e65508db73e1
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/7cb113c3ce0c
BuildID   20140917160201
Version   34.0a2
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Comment 1

[Eric Chang [:ericcc] [:echang]]

[Blocking Requested - why for this release]: Regression

Comment 2

[Anthony Ricaud (:rik)]

I think this was done in bug 927862.

Alive: Can you help us find the desired visual for this?

Comment 3

[Gregor Wagner [:gwagner]]

Regression

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20140903023250
Gaia: 921e0d335137cd7cc8e963eedbb1669ea52e3ca5
Gecko: 0423914fbba9
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20140903024856
Gaia: 64925bef8196ddae04dcf189beb346f3ee459ffd
Gecko: a3ad2366ec45
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First broken gaia & Last working gecko - issue DOES repro
Gaia: 64925bef8196ddae04dcf189beb346f3ee459ffd
Gecko: 0423914fbba9

First broken gecko & Last working gaia - issue does NOT repro
Gaia: 921e0d335137cd7cc8e963eedbb1669ea52e3ca5
Gecko: a3ad2366ec45

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/921e0d335137cd7cc8e963eedbb1669ea52e3ca5...64925bef8196ddae04dcf189beb346f3ee459ffd

Caused by bug 1055577.

Comment 5

[Joshua Mitchell (Inactive)]

possibly broken by bug 1055577 - can you take a look Greg?

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/24315

Broken by the notifications restyle I think

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8493510 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24315

lgtm!

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/f911b47f1acfb8e229851d443692115caf8369e0

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8493510 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24315

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
The is caused by the co-landing of attention window (bug 927862) and the notification restyle which are both v2.1 feature.
[User impact] if declined:
User will feel UI is wrong
[Testing completed]:
Yes
[Risk to taking this patch] (and alternatives if risky):
No, CSS only change
[String changes made]:
No

Comment 10

[bhavana bajaj [:bajaj]]

Comment on attachment 8493510 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24315

Approving as this is a low risk css patch fixing a regression

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/f5793c67e4ff4920e196e78698c68a0cb231c88d

Comment 12

[Eric Chang [:ericcc] [:echang]]

Gaia-Rev        778ebac47554e1c4b7e9a952d73e850f58123914
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/aa98eb8873a2
Build-ID        20141005160206
Version         34.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141005.194124
FW-Date         Sun Oct  5 19:41:35 EDT 2014
Bootloader      L1TC00011840

Comment 13

[Seth Miko [:SMiko]]

Verified fixed on Flame 2.2 (319mb/full flash) and Flame 2.1 (319mb/full flash) 

Actual result: Callscreen Icon on notification tray displays at normal size.

Device: Flame 2.2
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0