1069240 - Menu icon and the word "menu" within a link in sync.lang need swapping places

Status: VERIFIED FIXED

(www.mozilla.org :: L10N, defect)

Description

[Besnik Bleta]

In step 1. of https://www-dev.allizom.org/sq/firefox/sync/ the icon for the menu and the word menu are within a link. For sq the right order should be:

1. Hapni menunë #

instead of

1. Hapni # menunë

(# used to represent the actual icon, the three paralel horizontal lines, the menu icon in Firefox. Sorry for not being able to reproduce it.)

Could the link be changed to something else in order to localize it properly?

Comment 1

[Francesco Lodolo [:flod]]

I'll take a look later. Since the link's CSS class is in the string, it should be possible to use a specify a different class in the localization.

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

The idea is to have a different CSS class ('menurev') that displays the icon after the text, and add a note to the string explaining how it can be changed.

While testing I also realized that the icon after the menu makes a lot more sense in Italian too.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a1bbf6b7e01ce57469c17a9c2a0b851e8a2ea985
Bug 1069240 - [Sync] Add extra class to display menu icon after the word

https://github.com/mozilla/bedrock/commit/405ec0466a3472dc64e6e28eda51deb752c35cc8
Merge pull request #2290 from flodolo/bug1069240

Bug 1069240 - [Sync] Add extra class to display menu icon after the word

Comment 4

[Francesco Lodolo [:flod]]

Also verified on prod with Firefox 30 UA.

@Besnik
I've already updated your string too.