1069290 - Remove redundant "--settings treeherder.settings" from update.py

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

manage.py set the DJANGO_SETTINGS_MODULE env variable:
https://github.com/mozilla/treeherder-service/blob/master/manage.py#L6

So afaict we shouldn't need to pass in the --settings treeherder.settings in update.py:
https://github.com/mozilla/treeherder-service/blob/master/deployment/update/update.py#L20
https://github.com/mozilla/treeherder-service/blob/master/deployment/update/update.py#L47

According to:
https://docs.djangoproject.com/en/1.5/topics/settings/#designating-the-settings

Not exactly high priority, but:
a) If we ever change the settings value in manage.py, update.py will be out of sync
b) I was using update.py as a command cheatsheet and was pointlessly typing out the --settings foo each time.

Comment 1

[Ed Morley [:emorley]]

Attachment: Remove redundant manage.py params from the deploy script

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/2b8b12db78f9216d185d2020d566e02ec0f1b75d
Bug 1069290 - Remove redundant manage.py params from the deploy script

manage.py sets the DJANGO_SETTINGS_MODULE env variable, so it's
unnecessary to pass |--settings ...| when we call it from the Chief
deploy script.

Comment 3

[Ed Morley [:emorley]]

Attachment: manage.py should overwrite DJANGO_SETTINGS_MODULE if set

So unfortunately with the patch that has landed, since manage.py uses setdefault(), it means we only set DJANGO_SETTINGS_MODULE if it was not already defined in the environment. However for the Chief deploys, it is already set to "chief.settings":
http://treeherderadm.private.scl3.mozilla.com/chief/treeherder.prod/logs/master.1411472040

Given that one off commands can use --settings "foo" to override the value of DJANGO_SETTINGS_MODULE, I'd prefer to just set DJANGO_SETTINGS_MODULE unconditionally to "treeherder.settings", rather than have to make update.py unnecessarily complicated.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/2cae1d2dab57f44110f618526831d9c02bb58f9a
Bug 1069290 - manage.py should overwrite DJANGO_SETTINGS_MODULE if set

Comment 5

[Ed Morley [:emorley]]

Working now :-)

http://treeherderadm.private.scl3.mozilla.com/chief/treeherder.prod/logs/master.1411475198