1069310 - Invalid config.pp for servo buildbot master in puppet

Status: RESOLVED DUPLICATE of bug 1067951

(Release Engineering :: General, defect)

Description

[Pete Moore [:pmoore][:pete]]

There seems to be a spurious } here:
https://github.com/mozilla/build-puppet/commit/242677be#diff-95f5e5014fccc30fea765063f72dca17R55

It seems to be causing, e.g.:
https://foreman.pub.build.mozilla.org/reports/10427674

"Could not retrieve catalog from remote server: Error 400 on SERVER: Could not parse for environment production: Syntax error at '}' at /etc/puppet/production/manifests/config.pp:88 on node buildbot-master-servo-01.srv.servo.releng.use1.mozilla.com"

Comment 1

[Pete Moore [:pmoore][:pete]]

Attachment: bug1069310_puppet_v1.patch

I wonder if we could set up unit tests to validate puppet changes, and what would be involved to set that up.

Comment 2

[Pete Moore [:pmoore][:pete]]

(specifically, I mean things like syntax errors)

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

We could add validation, perhaps in Jenkins, or even Travis.  Unit tests are harder -- lots of work to set up, and still not an especially realistic simulation of what happens on the target machine (for example, you can write a spec that says "when I include packages::wget on a system with $operatingsystem = "CentOS", it creates a Package['wget'] resource", but that can't replace actually trying it on a CentOS box, at which point the unit test is pretty useless).

Validation will only catch a small fraction of errors, but certainly would have caught this one.