1069321 - "Unsuported browser" error while reloading the "Start call" page in offline mode

Status: RESOLVED WORKSFORME

(Hello (Loop) :: Client, defect, P5)

Description

[Paul Silaghi, QA [:pauly]]

STR:
1. Click on the Loop icon and copy the Loop URL
2. Paste & Go to the Loop URL -> 'Start call' page shows up
3. Enter Offline mode
4. Reload the 'Start call' page

AR: "Incompatible Browser
The audio and video components of WebRTC! are powered by WebRTC.
Please try this link in a WebRTC-enabled browser, such as Firefox."

Comment 1

[Paul Silaghi, QA [:pauly]]

Last good revision: 053a96e40244 (2014-08-16)
First bad revision: 94ba78a42305 (2014-08-17)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=053a96e40244&tochange=94ba78a42305

Last good revision: fd08e61066de
First bad revision: 229181c88a3c
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=fd08e61066de&tochange=229181c88a3c

Comment 2

[Paul Silaghi, QA [:pauly]]

It seems to be a regression, though I'm not sure that before bug 1029155 the problem was just hidden by the "Offline mode" page.

Comment 3

[:shell escalante]

very edge.  it is an odd error message for us to fall back to - if possible change.  may be getting wrong info from platform.

maire is going to look at to clean up and get in right area - likely still low pri.

Comment 4

[Maire Reavy [:mreavy]]

I need to know how the sdk is testing for webrtc functionality.  This could be a bug in the sdk(how it is querying for the info) or it could be a bug in what the platform is returning. If someone can tell me what the sdk is checking for, I can investigate it on the platform side.

Comment 5

[Mark Banner (:standard8)]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #4)
> I need to know how the sdk is testing for webrtc functionality.  This could
> be a bug in the sdk(how it is querying for the info) or it could be a bug in
> what the platform is returning. If someone can tell me what the sdk is
> checking for, I can investigate it on the platform side.

The sdk used to check for:

if (typeof(window.mozRTCPeerConnection) === 'function' && OT.$.env.version > 20.0) {
  try {
    new window.mozRTCPeerConnection();
    return true;
  } catch (err) {
    return false;
  }
}

So the "new window.mozRTCPeerConnection" would throw when in offline mode.

The latest sdk versions are now running without the new check and just the check to see if it is a function.

Therefore, I think this can be WFM unless you still want to change something on the platform side.

Comment 6

[Maire Reavy [:mreavy]]

Thanks, Mark. I think we're good here.