1069330 - [Loop] Wrong Audio call mode when default call mode is set to Audio, once logout and login is done again.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Comment 1

[Javier de Prado]

ENV:
Device: flame
LoopClient: 3cd2086
Build: flame-KK.user.v2.0.B-3.Gecko-2e0f023.Gaia-31434a3
RAM=512M

STR:
1. Open Loop app
2. Set Default call mode in Settings to "Audio"
3. Done.
4. Make a call and verify that it's an outgoing audio call, and the icon in the call log is audio.
5. Logout from loop settings
6. Login again and check in settings, that default call mode remains to "Audio"
7. Make a call again

ACTUAL RESULT: Ongoing call and its corresponding icon y call log, are VIDEO.

EXPECTED RESULT: Ongoing call should be audio call (and its corresponding icon in the call log)

Comment 2

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 3

[Borja Salguero [:borjasalguero]]

(In reply to Javier de Prado from comment #1)
> EXPECTED RESULT: Ongoing call should be audio call (and its corresponding
> icon in the call log)

When logging out we are deleting all the old preferences stored, so the 'video' default returns to 'true'.
Currently we have no way to store this params in the Server, so we should open a followup in order to track this new feature.

Comment 4

[Borja Salguero [:borjasalguero]]

Comment on attachment 8493031 [details]
Pull Request

https://github.com/mozilla-b2g/firefoxos-loop-client/pull/128

Comment 5

[Maria Angeles Oteo (:oteo)]

(In reply to Borja Salguero [:borjasalguero] from comment #3)

> 
> When logging out we are deleting all the old preferences stored, so the
> 'video' default returns to 'true'.
> Currently we have no way to store this params in the Server, so we should
> open a followup in order to track this new feature.

Thanks Borja!
Let's fix in this bug the incoherent UI, so if, after logging out and logging in again, the Loop settings are set again to their default values ("Video"/"Front Camera") , Settings application will update the UI according to it.

I will track with Product team the functionality of keeping/recovering the Loop parameters and will open that follow-up bug if it's necessary.

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8493031 [details]
Pull Request

LGTM, r=me.

Thanks for taking care of it Borja!

Comment 7

[Maria Angeles Oteo (:oteo)]

> 
> I will track with Product team the functionality of keeping/recovering the
> Loop parameters and will open that follow-up bug if it's necessary.

Confirmed with Product team, that for this first Loop Mobile version we will not address this issue, in the same way that the Call log history does not persist when logging out

Comment 8

[Javier de Prado]

Verified on loop 1.1, V.e01ef76
Flame: 2.0.184based.Gecko-675d616.Gaia-2183b4f
FireE: firee-kk-v2.0-SW2E5-4