Closed Bug 1069377 Opened 10 years ago Closed 10 years ago

Add aria group and label to each card in cards view

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Window Mgmt
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S8 (20mar)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: eeejay, Assigned: rfkdali, Mentored)

References

Details

(Keywords: access, Whiteboard: [b2ga11y p=1])

Attachments

(2 files)

add role group to each cards
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
https://github.com/mozilla-b2g/gaia/pull/28721
48 bytes, text/x-github-pull-request
etienne
: review+
bajaj
: approval-gaia-v2.2+
Details | Review
This will associate the "open" and "close" buttons with the app name so that screen reader users will know what they are opening and closing.
What is the cards and cards view ?
Flags: needinfo?(eitan)
When a few apps are open, you can long-press the home button. This brings up a "cards view" of all the apps so you can switch between them.
Flags: needinfo?(eitan)
ok but I don't found where are the code for UI of this function
Flags: needinfo?(eitan)
Attachment #8530909 - Flags: review?(alive)
Attachment #8530909 - Flags: review?(alive) → review+
do I need to make something more ?
Flags: needinfo?(eitan)
(In reply to aurelien levy from comment #6) > do I need to make something more ? I just tested, and this works good. Thanks!
Flags: needinfo?(eitan)
Mentor: etienne
Attachment #8574704 - Flags: review?(etienne)
Comment on attachment 8574704 [details] [review] https://github.com/mozilla-b2g/gaia/pull/28721 All good, will merge as soon as we have a green try!
Attachment #8574704 - Flags: review?(etienne) → review+
Landed on master: https://github.com/mozilla-b2g/gaia/commit/632b3f518d7e7ffa686dca06a97e726aba24243d Congrats!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8574704 [details] [review] https://github.com/mozilla-b2g/gaia/pull/28721 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): improvement, not a bug [User impact] if declined: group semantics will be lost for cards in cards view [Testing completed]: unit and on device [Risk to taking this patch] (and alternatives if risky): low [String changes made]: none
Attachment #8574704 - Flags: approval-gaia-v2.2?
Attachment #8574704 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
v2.2: https://github.com/mozilla-b2g/gaia/commit/f5e18016acd43bd6dc25a69778b2fc03197a227a
Assignee: nobody → rfkdali
status-b2g-v2.2: --- → fixed
status-b2g-master: --- → fixed
Target Milestone: --- → 2.2 S8 (20mar)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: