Closed Bug 1069418 Opened 10 years ago Closed 10 years ago

Improve PHP code of the product details

Categories

(www.mozilla.org :: Product Details, defect)

Product:
www.mozilla.org
Component:
Product Details
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

improve-php-syntax.diff
6.50 KB, patch
pascalc
: review+
Details | Diff | Splinter Review
Discussing with Pascal, he suggested to use const instead of define in the php code for readability. He also recommended to get ride of the ?> at the end of the php file: http://php.net/manual/en/language.basic-syntax.phptags.php
Attachment #8491583 - Flags: review?(pascalc)
Attachment #8491583 - Flags: review?(lmandel)
Of course, the export json and the sanity checks still work.
Assignee: nobody → sledru
Component: Release Automation → Product Details
Product: Release Engineering → www.mozilla.org
QA Contact: bhearsum
Comment on attachment 8491583 [details] [diff] [review] improve-php-syntax.diff The changes look good to me
Attachment #8491583 - Flags: review?(pascalc) → review+
Comment on attachment 8491583 [details] [diff] [review] improve-php-syntax.diff Thanks! merged: http://viewvc.svn.mozilla.org/vc?view=revision&revision=131971
Attachment #8491583 - Flags: review?(lmandel)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: