Closed
Bug 1069484
Opened 10 years ago
Closed 10 years ago
Usage: Main screen: Usage type and amount should be unified.
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yzen, Assigned: eeejay)
References
Details
(Keywords: access, Whiteboard: [b2ga11y p=1][NaBfT])
Attachments
(1 file)
Right now it is possible to navigate separately to the text representing the usage type and the text representing the amount. A good solution is to unify those to things into 1 item so the screen reader user hears both the usage type and amount at once.
Updated•10 years ago
|
Whiteboard: [b2ga11y p=1] → [b2ga11y p=1][NaBfT]
Assignee | ||
Comment 1•10 years ago
|
||
I tweaked the gaia-checkbox styling as well to make it easier to drop in place of BB checkboxes.
Attachment #8517619 -
Flags: review?(salva)
Attachment #8517619 -
Flags: review?(kgrandon)
Comment 3•10 years ago
|
||
Comment on attachment 8517619 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25852 I think that the main usage of the gaia-checkboxes were geared towards the settings app. I think by doing these changes it might make it harder to get into places like the settings app? Seems fine for now, but we might have to revisit this in the future. Thanks for the patch!
Attachment #8517619 -
Flags: review?(kgrandon) → review+
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → eitan
Status: NEW → ASSIGNED
Comment 4•10 years ago
|
||
Comment on attachment 8517619 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25852 The patch looks great but I would someone from the Web Components team to review the patch as it is including changes outside the Cost Control application.
Attachment #8517619 -
Flags: review?(salva) → review+
Comment 6•10 years ago
|
||
(In reply to Salvador de la Puente González [:salva] from comment #5) > Kevin, was you who write the check-box part? Yes, I believe my review should be fine for this part of the PR.
Flags: needinfo?(kgrandon)
Assignee | ||
Comment 7•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/5ae28ff11b982e2bd7d1aa097cda131536952bdc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•