Closed
Bug 1069490
Opened 6 years ago
Closed 6 years ago
Add column number to ConsoleEvent, ConsoleStackEntry, nsIStackFrame
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(4 files)
1.38 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
5.01 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
1.57 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
4.60 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
In bug 1060161 we started printing out stack traces with console messages on b2g devices. It was noted that having a column number in addition to a line number would be useful (particularly for minified code). My proposal is: #1 - add an |unsigned long columnNumber| to ConsoleEvent [1] and ConsoleStackEntry [2] #2 - add a |readonly attribute int32_t columnNumber| to nsIStackFrame [3] #3 - |StackFrameToStackEntry| [4] would set ConsoleStackEntry's column number #4 - add a |GetColumnNumber| to JSStackFrame [5] that queries "column" value of the JS stack object [1] http://hg.mozilla.org/mozilla-central/annotate/426497473505/dom/webidl/Console.webidl#l35 [2] http://hg.mozilla.org/mozilla-central/annotate/426497473505/dom/webidl/Console.webidl#l67 [3] http://hg.mozilla.org/mozilla-central/annotate/426497473505/xpcom/base/nsIException.idl#l14 [4] http://hg.mozilla.org/mozilla-central/annotate/426497473505/dom/base/Console.cpp#l752 [5] http://hg.mozilla.org/mozilla-central/annotate/426497473505/dom/bindings/Exceptions.cpp#l264
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #8491925 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•6 years ago
|
Attachment #8491928 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•6 years ago
|
Attachment #8491929 -
Flags: review?(bzbarsky)
![]() |
||
Comment 4•6 years ago
|
||
Comment on attachment 8491925 [details] [diff] [review] Part 1: Add columnNumber to ConsoleEvent and ConsoleStackEntry r=me
Attachment #8491925 -
Flags: review?(bzbarsky) → review+
![]() |
||
Comment 5•6 years ago
|
||
Comment on attachment 8491928 [details] [diff] [review] Part 2: Add columnNumber to nsIStackFrame and set in JSStackFrame r=me
Attachment #8491928 -
Flags: review?(bzbarsky) → review+
![]() |
||
Comment 6•6 years ago
|
||
Comment on attachment 8491929 [details] [diff] [review] Part 3: Set columnNumber when processing console messages r=me. Thank you for breaking this up into nice easy to digest chunks!
Attachment #8491929 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 7•6 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #6) > Comment on attachment 8491929 [details] [diff] [review] > Part 3: Set columnNumber when processing console messages > > r=me. Thank you for breaking this up into nice easy to digest chunks! Thanks for the quick reviews! Try is running, I expect that I'll need to fix a few tests when the results come in: https://tbpl.mozilla.org/?tree=Try&rev=d965bae7a732
Assignee | ||
Comment 8•6 years ago
|
||
Rob, can you take a look at these test updates that handle the new |columnNumber| field on stack traces?
Attachment #8492489 -
Flags: review?(rcampbell)
Assignee | ||
Comment 9•6 years ago
|
||
Rerunning try against bc and dt: https://tbpl.mozilla.org/?tree=Try&rev=d719537dfe85
Comment on attachment 8492489 [details] [diff] [review] Part 4: Update tests Reassigning since Rob is out.
Attachment #8492489 -
Flags: review?(rcampbell) → review?(past)
Updated•6 years ago
|
Attachment #8492489 -
Flags: review?(past) → review+
Assignee | ||
Comment 11•6 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/3dae455e39d2 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/b0dd65a5d40b remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/55363f62f7ad remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/31ff3ab5c143
https://hg.mozilla.org/mozilla-central/rev/3dae455e39d2 https://hg.mozilla.org/mozilla-central/rev/b0dd65a5d40b https://hg.mozilla.org/mozilla-central/rev/55363f62f7ad https://hg.mozilla.org/mozilla-central/rev/31ff3ab5c143
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•6 years ago
|
Flags: qe-verify-
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•