1069493 - Stop mirroring failure classifications to TBPL's submitBuildStar.php when EOL is imminent

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

When we're ready for TBPL to be switched off, we should stop mirroring failure classifications in treeherder to TBPL's submitBuildStar.php:

https://github.com/mozilla/treeherder-service/blob/e5967822541cb0a6fbdf954273bb79830d13370d/treeherder/model/derived/jobs.py#L541

https://github.com/mozilla/treeherder-service/blob/e5967822541cb0a6fbdf954273bb79830d13370d/treeherder/etl/tbpl.py#L74

https://github.com/mozilla/treeherder-service/blob/e5967822541cb0a6fbdf954273bb79830d13370d/treeherder/etl/tasks.py#L107

If the current implementation is able to handle submitBuildStar.php not responding, then this bug can wait until after TBPL EOL if needs be, or if not, we'll need to do this prior.

Comment 1

[Mauro Doglio [:mdoglio]]

The current implementation uses an asynchronous task to communicate with tbpl, so there wouldn't be any service disruption if tbpl was down. We can EOL tbpl and then switch the TBPL_BUGS_TRANSFER_ENABLED setting.

Comment 2

[Ed Morley [:emorley]]

Great :-)

Comment 3

[Ed Morley [:emorley]]

Attachment: Stop mirroring classification comments to TBPL's DB

Comment 4

[Ed Morley [:emorley]]

(In reply to Mauro Doglio [:mdoglio] from comment #1)
> We can EOL tbpl and then switch the TBPL_BUGS_TRANSFER_ENABLED setting.

The TBPL_BUGS_TRANSFER_ENABLED setting controls submitting to Bugzilla and also Elastic search. We'll want to continue doing both of those, which is why the PR here doesn't remove that pref. They'll be handled in bug 1069560 / bug 1069502.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/b16eff0d2b2c862f4130d306a66d13a9344a9fe0
Bug 1069493 - Stop mirroring classification comments to TBPL's DB

TBPL is going to be EOLed soon, and few people are still using it. As
such we can stop mirroring failure classification comments to
submitBuildStar.php.

Comment 6

[Ed Morley [:emorley]]

Thanks :-)