1069499 - [Dialer] [User Story] It should be possible to easily delete single entry from the call log list

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Safwan Rahman (:safwan)]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140911151253

Steps to reproduce:

# Open the Dialer(Phone) application
# Go to the call log
# Long tap on any entry


Actual results:

You will see options for "Add to existing contact", "create new contact" and "send message" menu.


Expected results:

Should also see "Delete" for deleting the entry from the log list.

Currently, need to tap on the menu of the top right corner and chose the entry to delete it. This system may be good for deleting many entries, but not good for deleting only one entry. This system for deleting a single entry really time consuming.

Comment 1

[Doug Sherk (:drs) (inactive)]

This seems like a reasonable request to me. The SMS app has a "delete" option in its long press menu for messages, but not for threads, so there's definitely at least some precedent here.

Carrie, what do you think?

Comment 2

[Carrie Wang [New account: [e-mail]]]

Yes, agree. So shall we move it to backlog pool? Thanks!

Comment 3

[Goutam(:goutamnair)]

Hey, I would like to work on this. Can this be assigned to me?

Comment 4

[Doug Sherk (:drs) (inactive)]

Ok, great! Please don't hesitate to ask me questions. I would suggest starting here:
https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia

Are you on IRC? If not, this will help you get setup:
https://wiki.mozilla.org/IRC

You can join #fxos-dialer and #gaia, though the former is better to talk with us about this bug.

Comment 5

[Doug Sherk (:drs) (inactive)]

Hi Goutam, are you working on this?

Comment 6

[Goutam(:goutamnair)]

Hey Doug, I have been busy for some days now and I have my exams coming up. Could I resume working on it after a couple of days?

Comment 7

[Doug Sherk (:drs) (inactive)]

(In reply to Goutam(:goutamnair) from comment #6)
> Hey Doug, I have been busy for some days now and I have my exams coming up.
> Could I resume working on it after a couple of days?

Sure. I'm going to unassign this for now. If you have time later, and this isn't taken by someone else, please let me know and I'd be happy to get started with you on it again.

Comment 8

[peter.pistorius]

I wouldn't mind working on this!

Comment 9

[Safwan Rahman (:safwan)]

(In reply to peter.pistorius from comment #8)
> I wouldn't mind working on this!

Peter, Thanks a lot for your eager to working on this!
Go on and make this bug solved as soon as possible. Waiting eagerly to see your code running in Firefox OS! I am assigning you for this bug. Thanks again

Comment 10

[Doug Sherk (:drs) (inactive)]

Thanks, Safwan.

Peter, please see comment 4 for info on getting started. Don't hesitate to contact me for any questions or help that you need.

Comment 11

[peter.pistorius]

Thanks Safwan and Doug. I'm too looking forward to getting some code into Firefox OS!

Comment 12

[Doug Sherk (:drs) (inactive)]

Peter told us over IRC that he's actively working on this, so I'm setting it to ASSIGNED. Thanks for joining us, Peter!

Comment 13

[peter.pistorius]

Attachment: Added `delete` to the context menu in the call log

Comment 14

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8525994 [details] [review]
Added `delete` to the context menu in the call log

Redirecting to Tamara. I will review this as well once Tamara gives r+.

Comment 15

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8525994 [details] [review]
Added `delete` to the context menu in the call log

Oops. Tamara, not me.

Comment 16

[Tamara Hills [:thills]]

Comment on attachment 8525994 [details] [review]
Added `delete` to the context menu in the call log

Hi Peter,

Thank you Peter.  Looks very nice so far.  It's working good for me when I tested everything out!  I left two comments in the PR.  

I think we should add a test to make sure that the entry gets deleted from the CallLogDB and that the DOM gets updated properly as well.

The other thing I thought about was whether there is a way to share some common code with what's in CallLog.deleteLogGroups.  I looked at it for a bit, but didn't see anything really easy.  Maybe something you can look at and see if I missed anything there.

Also, I'm just starting to do reviews so Doug will review after I'm done as well.

Thanks,
-tamara

Comment 17

[peter.pistorius]

Thanks @thills, I appreciate the time you've taken to review this and I'll fix up those issue ASAP, add the new tests, and see if I can share some common code.

Comment 18

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8525994 [details] [review]
Added `delete` to the context menu in the call log

Peter, are you still working on this? We can help you write the tests if you'd like.

Comment 19

[peter.pistorius]

Doug, Yes I am, but I'm on vacation at the moment. I'll  be back on the 5th. I'll appreciate some help when I get back.

Comment 20

[Doug Sherk (:drs) (inactive)]

Unassigning as there has been no activity on this.

Comment 21

[Samia Shafique]

hello. 
I am a new to bug fixing and would like to work on this bug if no one is currently working on it. 
Thanks.

Comment 22

[varghesethomase]

Hi, 
I would like to work on this. Need some help for writing the tests though, as I am new to it. 

Thanks

Comment 23

[BMO Automation]

Firefox OS is not being worked on