Icons should be centered inside each "button" and not on the middle of the screen. (see attachment)
Regression was introduced by commit 4c66010769 (Bug 1064744)
Hi Arnau, the patch for Bug 1064744 introduced this regression, do you have any recommendations? (ie. should we back out your patch)
I'll take this one. Sorry for breaking it!
Assignee: nobody → rnowmrch
Hey Miller, I have revisited the visual specs for Toolbar component. This patch could easily be solved by adding `position: relative` in the buttons, but I have also moved some properties from calendar settings.css to the BB, so it's easier to do future changes in case visuals changes again. Thanks!
Attachment #8492078 - Flags: review?(mmedeiros)
Comment on attachment 8492078 [details] [review] patch in github LGTM! I agree that moving as much logic as possible into BB will be better for future updates.
Attachment #8492078 - Flags: review?(mmedeiros) → review+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
This issue is verified fixed on Flame 2.2. Result: The sync and gear icons are displayed properly without overlapping. Device: Flame 2.2 (319mb, KK, Shallow Flash) BuildID: 20141121040204 Gaia: 25388c6bce932657ebf93adedf31881bfaf88c15 Gecko: 3366c0fcf9c2 Version: 36.0a1 (2.2) Firmware Version: v188-1 User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
You need to log in before you can comment on or make changes to this bug.