Closed Bug 1069559 Opened 11 years ago Closed 11 years ago

Implement dynamic pinning backend and idls for trusted Apps

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35
Tracking Flags:
Tracking Status
firefox33 --- wontfix
firefox34 --- fixed
firefox35 --- fixed
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: cviecco, Assigned: cviecco)

References

Details

Attachments

(3 files)

pinning-tako-imp-aurora
44.72 KB, patch
cviecco
: review+
lmandel
: approval-mozilla-aurora+
Details | Diff | Splinter Review
pinning-tako-idl
3.63 KB, patch
cviecco
: review+
lmandel
: approval-mozilla-aurora+
Details | Diff | Splinter Review
pinning-tako-tests
40.22 KB, patch
cviecco
: review+
lmandel
: approval-mozilla-aurora+
Details | Diff | Splinter Review
This is post landing split of bug Bug 787133 so that the trusted app section can be easily tracked
Blocks: hpkp, 1016421
This is the same as: https://bugzilla.mozilla.org/attachment.cgi?id=8490886 but rebased for aurora. r+ by keeler
Attachment #8491743 - Flags: review+
Attached patch pinning-tako-idl — — Splinter Review
r+ by keeler as part of bug 787133.
Attachment #8491744 - Flags: review+
r+ by keeler as part of bug 787133
Attachment #8491745 - Flags: review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 8491743 [details] [diff] [review] pinning-tako-imp-aurora Approval Request Comment [Feature/regressing bug #]:[Feature/regressing bug #]: This is required for 1016421 [User impact if declined]: Cannot do trusted apps [Describe test coverage new/current, TBPL]: Added new xpchsell tests for all functionality. [Risks and why]: Might break HSTS, as it changes some interals of its storage. However all tests pass. [String/UUID change made/needed]: In another part: UUID update for nsSiteSecurityService, two new functions where added (one of them c++ only)
Attachment #8491743 - Flags: approval-mozilla-aurora?
Comment on attachment 8491744 [details] [diff] [review] pinning-tako-idl Approval Request Comment [Feature/regressing bug #]: This is required for 1016421 [User impact if declined]: Cannot do trusted apps [Describe test coverage new/current, TBPL]: Added new xpchsell tests for all functionality. [Risks and why]: Might break HSTS, as it changes some interals of its storage. However all tests pass. [String/UUID change made/needed]: UUID update for nsSiteSecurityService, two new functions where added (one of them c++ only)
Attachment #8491744 - Flags: approval-mozilla-aurora?
Comment on attachment 8491745 [details] [diff] [review] pinning-tako-tests Approval Request Comment [Feature/regressing bug #]:[Feature/regressing bug #]: This is required for 1016421 [User impact if declined]: Cannot do trusted apps [Describe test coverage new/current, TBPL]: Added new xpchsell tests for all functionality. [Risks and why]: Might break HSTS, as it changes some interals of its storage. However all tests pass. [String/UUID change made/needed]: In another part: UUID update for nsSiteSecurityService, two new functions where added (one of them c++ only)
Attachment #8491745 - Flags: approval-mozilla-aurora?
Comment on attachment 8491743 [details] [diff] [review] pinning-tako-imp-aurora Aurora+
Attachment #8491743 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8491744 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8491745 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee: nobody → cviecco
status-b2g-v2.1: --- → fixed
status-b2g-v2.2: --- → fixed
status-firefox33: --- → wontfix
status-firefox34: --- → fixed
status-firefox35: --- → fixed
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: