1069562 - Usage: Main screen: Unify app mobile usage as list items

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Right now the screen reader goes over all text entries in the list of per app usage. We need to announce all of that info as one entry.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25901

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 8518378 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25901

I'm not an expert in usability, although the code looks ok, could you please clarify me why are you adding the presentation role, please? Thank you!

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to Salvador de la Puente González [:salva] from comment #2)
> Comment on attachment 8518378 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25901
> 
> I'm not an expert in usability, although the code looks ok, could you please
> clarify me why are you adding the presentation role, please? Thank you!

The presentation role is used for elements that don't play a semantic role, and are there purely for visual styling. The classic example is using table HTML for layout, giving the table and cell elements a role of "presentation" assures us that screen reader users won't hear "table, row, column", etc.

A container with a role of "presentation" is removed from the accessibility hierarchy, but its children are *not*, they become direct descendants of the "presentation" container's parent.

In the case of this patch, I chose to give the icon a role of presentation, since we already have the application name, and it does not relay any new information. Same with the bar that gives a visual approximation of the amount of data, the number is also explicitly displayed. This cleans up the list item, so when a user navigates to it with a screen reader they hear "Browser, 2.2 megabytes" as opposed to "Image, Browser, Paragraph, 2.2 megabytes", which is very chatty and useless.

Hope that answers your question!

Comment 4

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/d25927d1f366192f08df656798143e0cb5e23f8d