1069593 - Usage: Main screen: make usage graph accessible.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

The screen reader should be able to navigate the time scale incrementally and announce the usage for all selected categories for the current date interval. It also needs to announce the limit.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] yzen:bug-1069593 to mozilla-b2g:master

Comment 2

[Marina Rodríguez [:mai]]

Comment on attachment 8562181 [details] [review]
[PullReq] yzen:bug-1069593 to mozilla-b2g:master

Seems fine to me, thanks for working on this,

Regards,
 Marina

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8562181 [details] [review]
[PullReq] yzen:bug-1069593 to mozilla-b2g:master

Addressed your comment, thanks!

Comment 4

[Marina Rodríguez [:mai]]

Comment on attachment 8562181 [details] [review]
[PullReq] yzen:bug-1069593 to mozilla-b2g:master

LGTM, r+, thanks for the effort.

PS: I've been testing the patch and it works great, but I miss the data info about the wifi and mobile traffic layer. IMHO, it could be interesting add info about the total amount of traffic, but I don't know if this could be a lot of redundant info. Would you mind put a ni to accesibility team about this issue and  open a follow up to add this info if they think that it is necessary?.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Marina Rodríguez [:mai] from comment #4)
> Comment on attachment 8562181 [details] [review]
> [PullReq] yzen:bug-1069593 to mozilla-b2g:master
> 
> LGTM, r+, thanks for the effort.
> 
> PS: I've been testing the patch and it works great, but I miss the data info
> about the wifi and mobile traffic layer. IMHO, it could be interesting add
> info about the total amount of traffic, but I don't know if this could be a
> lot of redundant info. Would you mind put a ni to accesibility team about
> this issue and  open a follow up to add this info if they think that it is
> necessary?.

I actually did not add it on purpose as this information is available right after the graphic (where we have totals for both mobile and wifi usage). I was trying to remain as terse as possible and not overwhelm the screen reader users with a giant sentence (almost a paragraph) about the graph. This is also a sort of soft requirement for the screen reader speech - to keep it as short as possible.

Comment 6

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/28122

The pull request could not be applied to the integration branch. Please try again after current integration is complete. You may need to rebase your branch against the target branch.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/e249a07757414ab27ca4911f7cb7119416772df6

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8562181 [details] [review]
[PullReq] yzen:bug-1069593 to mozilla-b2g:master

[Approval Request Comment] This pull request makes graph in Costcontrol screen reader accessible
[Bug caused by] (feature/regressing bug #): improvement, not a bug
[User impact] if declined: if declined the graph information will not be accessible to screen reader users
[Testing completed]: unit tests + on device
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: https://github.com/mozilla-b2g/gaia/pull/28122/files#diff-e1b739d2c9ec9f01cd2a61e729bfcd03

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/56a03695645a89dde2899745b6f31cb4f17ed664